Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(argocd-image-updater): Fix checksum/cmd-params and checksum/cm to prevent unnecessary diffs #3028

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

fix(argocd-image-updater): Fix checksum/cmd-params and checksum/cm to prevent unnecessary diffs #3028

wants to merge 4 commits into from

Conversation

pgmgb
Copy link

@pgmgb pgmgb commented Nov 13, 2024 •
edited
Loading

Checklist:

  • I have bumped the chart version according to versioning
  • I have updated the documentation according to documentation
  • I have updated the chart changelog with all the changes that come with this pull request according to changelog.
  • Any new values are backwards compatible and/or have sensible default.
  • I have signed off all my commits as required by DCO.
  • My build is green (troubleshooting builds).

@pgmgb pgmgb changed the title Fix/argocd image updater checksum fix(argo-image-updater): Fix checksum/cmd-params and checksum/cm to prevent unnecessary diffs Nov 13, 2024
@pgmgb pgmgb changed the title fix(argo-image-updater): Fix checksum/cmd-params and checksum/cm to prevent unnecessary diffs fix(argocd-image-updater): Fix checksum/cmd-params and checksum/cm to prevent unnecessary diffs Nov 13, 2024
@jmeridth
Copy link
Member

question that is applicable here also: #3027 (comment)

@pgmgb
Copy link
Author

pgmgb commented Nov 14, 2024

question that is applicable here also: #3027 (comment)

Please see #3027 (comment), as it is the same pattern.

@pgmgb pgmgb force-pushed the fix/argocd-image-updater-checksum branch from 39f8cc0 to 3d079d6 Compare November 15, 2024 08:38
@mkilchhofer mkilchhofer marked this pull request as draft November 15, 2024 12:41
@mkilchhofer
Copy link
Member

I flip this PR back to "draft" mode as we should clarify your initial PR (for argo-cd) first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkilchhofer mkilchhofer Awaiting requested review from mkilchhofer mkilchhofer is a code owner

@jmeridth jmeridth Awaiting requested review from jmeridth jmeridth is a code owner

@yu-croco yu-croco Awaiting requested review from yu-croco yu-croco is a code owner

@mbevc1 mbevc1 Awaiting requested review from mbevc1

@pdrastil pdrastil Awaiting requested review from pdrastil

@tico24 tico24 Awaiting requested review from tico24

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
argocd-image-updater size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pgmgb @jmeridth @mkilchhofer @frans-otogone