Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(argo-cd): Remove unwanted newline on redis-init-secret job's imagepullsecrets #2931

Merged
merged 8 commits into from
Sep 20, 2024

Conversation

tico24
Copy link
Member

@tico24 tico24 commented Sep 20, 2024

Checklist:

  • I have bumped the chart version according to versioning
  • I have updated the documentation according to documentation
  • I have updated the chart changelog with all the changes that come with this pull request according to changelog.
  • Any new values are backwards compatible and/or have sensible default.
  • I have signed off all my commits as required by DCO.
  • My build is green (troubleshooting builds).

Before:

...
    spec:
      imagePullSecrets:
        
        - name: foo
      containers:
...

After

...
    spec:
      imagePullSecrets:
        - name: foo
      containers:
...

@tico24 tico24 self-assigned this Sep 20, 2024
@tico24 tico24 changed the title Redis init imagepullsecrets fix(argo-cd): Remove unwanted newline on redis-init-secret job's imagepullsecrets Sep 20, 2024
Signed-off-by: Tim Collins <[email protected]>
Signed-off-by: Tim Collins <[email protected]>
@github-actions github-actions bot added size/XS and removed size/S labels Sep 20, 2024
@tico24 tico24 marked this pull request as ready for review September 20, 2024 08:38
@yu-croco yu-croco merged commit c5e6458 into argoproj:main Sep 20, 2024
8 checks passed
@tico24 tico24 deleted the redis-init-imagepullsecrets branch September 20, 2024 11:24
rouke-broersma referenced this pull request in broersma-forslund/homelab Sep 20, 2024
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [argo-cd](https://redirect.github.com/argoproj/argo-helm) | patch |
`7.6.0` -> `7.6.1` |

---

### Release Notes

<details>
<summary>argoproj/argo-helm (argo-cd)</summary>

###
[`v7.6.1`](https://redirect.github.com/argoproj/argo-helm/releases/tag/argo-cd-7.6.1)

[Compare
Source](https://redirect.github.com/argoproj/argo-helm/compare/argo-cd-7.6.0...argo-cd-7.6.1)

A Helm chart for Argo CD, a declarative, GitOps continuous delivery tool
for Kubernetes.

#### What's Changed

- fix(argo-cd): Remove unwanted newline on redis-init-secret job's
imagepullsecrets by [@&#8203;tico24](https://redirect.github.com/tico24)
in
[https://github.com/argoproj/argo-helm/pull/2931](https://redirect.github.com/argoproj/argo-helm/pull/2931)

**Full Changelog**:
argoproj/argo-helm@argo-cd-7.6.0...argo-cd-7.6.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend Renovate](https://mend.io/renovate/).
View the [repository job
log](https://developer.mend.io/github/broersma-forslund/homelab).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC44MC4wIiwidXBkYXRlZEluVmVyIjoiMzguODAuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants