Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(argo-cd): Fix certificate template secretTemplateAnnotations null #2909

Merged
merged 1 commit into from
Sep 2, 2024
Merged

fix(argo-cd): Fix certificate template secretTemplateAnnotations null #2909

merged 1 commit into from
Sep 2, 2024

Conversation

eddyfussel
Copy link
Contributor

@eddyfussel eddyfussel commented Sep 2, 2024 •
edited
Loading

Checklist:

  • I have bumped the chart version according to versioning
  • I have updated the documentation according to documentation
  • I have updated the chart changelog with all the changes that come with this pull request according to changelog.
  • Any new values are backwards compatible and/or have sensible default.
  • I have signed off all my commits as required by DCO.
  • My build is green (troubleshooting builds).

@jmeridth
Copy link
Member

jmeridth commented Sep 2, 2024

@eddyfussel please sign your commit to satisfy DCO. git commit -s...

@eddyfussel eddyfussel force-pushed the fix/issue/2908 branch 3 times, most recently from e689a59 to 1377976 Compare September 2, 2024 15:14
@eddyfussel
Copy link
Contributor Author

@jmeridth thanks for the fast response, I signed DCO and now also got finally my git alias configured correctly. I've all created a bug here: #2908

jmeridth
jmeridth approved these changes Sep 2, 2024
View reviewed changes
Copy link
Member

@jmeridth jmeridth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mbevc1 mbevc1 merged commit 3a1066c into argoproj:main Sep 2, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbevc1 mbevc1 mbevc1 approved these changes

@jmeridth jmeridth jmeridth approved these changes

@mkilchhofer mkilchhofer Awaiting requested review from mkilchhofer mkilchhofer is a code owner

@yu-croco yu-croco Awaiting requested review from yu-croco yu-croco is a code owner

@pdrastil pdrastil Awaiting requested review from pdrastil pdrastil is a code owner

@tico24 tico24 Awaiting requested review from tico24 tico24 is a code owner

Assignees
No one assigned
Labels
argo-cd size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eddyfussel @jmeridth @mbevc1