chore(argo-cd): Support string type of "true" for statusbadge.enabled
#2895
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yu-croco <[email protected]>
yu-croco
commented
Aug 24, 2024
| @@ -183,7 +183,7 @@ Argo Configuration Preset Values (Influenced by Values configuration) | |||
| {{- define "argo-cd.config.cm.presets" -}} | |||
| {{- $presets := dict -}} | |||
| {{- $_ := set $presets "url" (printf "https://%s" .Values.global.domain) -}} | |||
| {{- if index .Values.configs.cm "statusbadge.enabled" | eq true -}} | |||
| {{- if eq (toString (index .Values.configs.cm "statusbadge.enabled")) "true" -}} | |||
There was a problem hiding this comment.
Existing example of supporting "true" .
yu-croco
requested review from
mbevc1,
mkilchhofer,
jmeridth,
pdrastil and
tico24
as code owners
mkilchhofer
approved these changes
Aug 25, 2024
mbevc1
approved these changes
Aug 27, 2024
rouke-broersma
referenced
this pull request
in broersma-forslund/homelab
Aug 27, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [argo-cd](https://togithub.com/argoproj/argo-helm) | patch | `7.4.5` -> `7.4.7` | --- ### Release Notes <details> <summary>argoproj/argo-helm (argo-cd)</summary> ### [`v7.4.7`](https://togithub.com/argoproj/argo-helm/releases/tag/argo-cd-7.4.7) [Compare Source](https://togithub.com/argoproj/argo-helm/compare/argo-cd-7.4.6...argo-cd-7.4.7) A Helm chart for Argo CD, a declarative, GitOps continuous delivery tool for Kubernetes. #### What's Changed - chore(argo-cd): Update dependency argoproj/argo-cd to v2.12.3 by [@​argoproj-renovate](https://togithub.com/argoproj-renovate) in [https://github.com/argoproj/argo-helm/pull/2897](https://togithub.com/argoproj/argo-helm/pull/2897) **Full Changelog**: argoproj/argo-helm@argo-cd-7.4.6...argo-cd-7.4.7 ### [`v7.4.6`](https://togithub.com/argoproj/argo-helm/releases/tag/argo-cd-7.4.6) [Compare Source](https://togithub.com/argoproj/argo-helm/compare/argo-cd-7.4.5...argo-cd-7.4.6) A Helm chart for Argo CD, a declarative, GitOps continuous delivery tool for Kubernetes. #### What's Changed - chore(deps): bump github/codeql-action from 3.26.2 to 3.26.5 in the dependencies group by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/argoproj/argo-helm/pull/2894](https://togithub.com/argoproj/argo-helm/pull/2894) - chore(deps): update renovatebot/github-action action to v40.2.7 by [@​argoproj-renovate](https://togithub.com/argoproj-renovate) in [https://github.com/argoproj/argo-helm/pull/2896](https://togithub.com/argoproj/argo-helm/pull/2896) - chore(argo-cd): Support string type of "true" for `statusbadge.enabled` by [@​yu-croco](https://togithub.com/yu-croco) in [https://github.com/argoproj/argo-helm/pull/2895](https://togithub.com/argoproj/argo-helm/pull/2895) **Full Changelog**: argoproj/argo-helm@argo-cd-7.4.5...argo-cd-7.4.6 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/broersma-forslund/homelab). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yNi4xIiwidXBkYXRlZEluVmVyIjoiMzguMjYuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2869
.Values.configs.cm."exec.enabled"supports string oftrue, though the official type in agro-helm is bool. So I think it's kind for users to align the behavior of.Values.configs.cm."statusbadge.enabled"as well.If I set
statusbadge.enabledas"true", helm template fails as below.*argo-helm provides the type of parameters (e.g. Argo CD Configs) and the type of
statusbadge.enabledis bool, so it's not a bug.Checklist: