Skip to content

Commit

Permalink
fix(argocd-apps): don't render empty app description (#2911)
Browse files Browse the repository at this point in the history
* fix(argocd-apps): don't render empty app description

Signed-off-by: Zoltán Reegn <[email protected]>

* chore: Apply suggestions from code review

Signed-off-by: Marco Maurer (-Kilchhofer) <[email protected]>

---------

Signed-off-by: Zoltán Reegn <[email protected]>
Signed-off-by: Marco Maurer (-Kilchhofer) <[email protected]>
Co-authored-by: Marco Maurer (-Kilchhofer) <[email protected]>
  • Loading branch information
reegnz and mkilchhofer authored Sep 10, 2024
1 parent 6873926 commit a344d64
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 4 deletions.
6 changes: 3 additions & 3 deletions charts/argocd-apps/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v2
name: argocd-apps
description: A Helm chart for managing additional Argo CD Applications and Projects
type: application
version: 2.0.0
version: 2.0.1
home: https://github.com/argoproj/argo-helm
icon: https://argo-cd.readthedocs.io/en/stable/assets/logo.png
keywords:
Expand All @@ -17,5 +17,5 @@ annotations:
fingerprint: 2B8F22F57260EFA67BE1C5824B11F800CD9D2252
url: https://argoproj.github.io/argo-helm/pgp_keys.asc
artifacthub.io/changes: |
- kind: added
description: make the chart use maps instead of lists
- kind: fixed
description: not rendering empty app description
4 changes: 3 additions & 1 deletion charts/argocd-apps/templates/projects.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,9 @@ spec:
{{- with $projectData.permitOnlyProjectScopedClusters }}
permitOnlyProjectScopedClusters: {{ . }}
{{- end }}
description: {{ $projectData.description }}
{{- with $projectData.description }}
description: {{ . }}
{{- end }}
{{- with $projectData.sourceRepos }}
sourceRepos:
{{- toYaml . | nindent 4 }}
Expand Down

0 comments on commit a344d64

Please sign in to comment.