Skip to content

Commit

Permalink
fix(argo-cd): Make the PathType configurable when using single ingres…
Browse files Browse the repository at this point in the history
…s resource in AWS (#2251)

* Make the PathType configurable when using single ingress resource in AWS

Signed-off-by: Tamas <[email protected]>

* update chart version and doc

Signed-off-by: Tamas <[email protected]>

* Fix reference to value in range

Signed-off-by: Tamas <[email protected]>

---------

Signed-off-by: Tamas <[email protected]>
Co-authored-by: Tamas <[email protected]>
  • Loading branch information
w32-blaster and Tamas authored Sep 7, 2023
1 parent 2557347 commit 258efc9
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions charts/argo-cd/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ appVersion: v2.8.2
kubeVersion: ">=1.23.0-0"
description: A Helm chart for Argo CD, a declarative, GitOps continuous delivery tool for Kubernetes.
name: argo-cd
version: 5.45.1
version: 5.45.2
home: https://github.com/argoproj/argo-helm
icon: https://argo-cd.readthedocs.io/en/stable/assets/logo.png
sources:
Expand All @@ -27,4 +27,4 @@ annotations:
url: https://argoproj.github.io/argo-helm/pgp_keys.asc
artifacthub.io/changes: |
- kind: fixed
description: fixed example for configs.styles to be sidebar instead of nav-bar
description: do not hardcode the pathtype of the grpc ingress rule when using a single ingress resource in aws alb
2 changes: 1 addition & 1 deletion charts/argo-cd/templates/argocd-server/ingress.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ spec:
{{- range $p := $paths }}
{{- if and $.Values.server.ingressGrpc.isAWSALB $.Values.server.ingressGrpc.enabled }}
- path: {{ $p }}
pathType: Prefix
pathType: {{ $.Values.server.ingressGrpc.pathType }}
backend:
service:
name: {{ template "argo-cd.server.fullname" $ }}-grpc
Expand Down

0 comments on commit 258efc9

Please sign in to comment.