-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui): support auto theme #20080
base: master
Are you sure you want to change the base?
feat(ui): support auto theme #20080
Conversation
Signed-off-by: linghaoSu <[email protected]>
✅ Preview Environment deployed on Bunnyshell
See: Environment Details | Pipeline Logs Available commands (reply to this comment):
|
✅ Preview Environment created on Bunnyshell but will not be auto-deployedSee: Environment Details Available commands (reply to this comment):
|
7aae4b1
to
1ab1ba8
Compare
/bns:deploy |
@CodiumAI-Agent /review |
PR Reviewer Guide 🔍(Review updated until commit 1ab1ba8)
|
/bns:deploy |
Persistent review updated to latest commit 1ab1ba8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested the change locally and it looks really good!
I wonder whether we should change the default preference to 'auto' though or leave it light as it was.
Also, PTAL at the Codium AI review, this is also an opportunity to test how accurate it is.
And could you change the title of the to PR feat(ui) from feat(theme)?
Signed-off-by: linghaoSu <[email protected]>
Signed-off-by: linghaoSu <[email protected]>
@reggie-k Thanks for your review! I've changed the title. Maybe it would be better to set the default theme to ‘light’. codiumAI
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would be fine with auto being the default but I don't think it's that important and not worth stalling the merge.
Fixes #20105
Before
Only support set theme manually
Now
Support set auto theme, would show theme determined by system theme.
2024-09-24.23.06.12720.mov
Checklist: