Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: changes to integrate custom healthcheck using argocd-extension (Issue #13589) #13963

Closed
wants to merge 0 commits into from

Conversation

Archu-SM
Copy link

@Archu-SM Archu-SM commented Jun 8, 2023

Story

@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

Patch coverage: 32.43% and no project coverage change.

Comparison is base (8840929) 49.55% compared to head (3d010fb) 49.55%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #13963   +/-   ##
=======================================
  Coverage   49.55%   49.55%           
=======================================
  Files         256      256           
  Lines       43920    43957   +37     
=======================================
+ Hits        21766    21785   +19     
- Misses      19990    20006   +16     
- Partials     2164     2166    +2     
Impacted Files Coverage Δ
util/settings/settings.go 49.51% <32.43%> (-0.18%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@todaywasawesome todaywasawesome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need all the dependency bumps for this feature to work? I would prefer a clean PR with just the feature changes needed and to leave the dependency bumps for a separate PR.

I would advise creating a new branch, cherry-picking only the required code over and then opening a new PR.

@Archu-SM
Copy link
Author

Do we need all the dependency bumps for this feature to work? I would prefer a clean PR with just the feature changes needed and to leave the dependency bumps for a separate PR.

I would advise creating a new branch, cherry-picking only the required code over and then opening a new PR.

Hi @todaywasawesome,
Thanks for pointing it.
We had only committed the 3 file changes. But I think the @dependabot added the other dependancy updates (especially go.mod and go.sum) files.
So we are planning to revert the changes and create a separate PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants