Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui): support auto theme #20080

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

feat(ui): support auto theme #20080

wants to merge 3 commits into from

Conversation

linghaoSu
Copy link
Contributor

@linghaoSu linghaoSu commented Sep 24, 2024 •
edited
Loading

Fixes #20105

image

Before

Only support set theme manually

Now

Support set auto theme, would show theme determined by system theme.

2024-09-24.23.06.12720.mov

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@linghaoSu linghaoSu requested a review from a team as a code owner September 24, 2024 15:08
@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Sep 24, 2024 •
edited
Loading

✅ Preview Environment deployed on Bunnyshell

Component Endpoints
argocd https://argocd-5hxsdn.bunnyenv.com/
argocd-ttyd https://argocd-web-cli-5hxsdn.bunnyenv.com/

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🔴 /bns:stop to stop the environment
  • 🚀 /bns:deploy to redeploy the environment
  • ❌ /bns:delete to remove the environment

@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Sep 24, 2024

✅ Preview Environment created on Bunnyshell but will not be auto-deployed

See: Environment Details

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@reggie-k
Copy link
Member

/bns:deploy

@reggie-k
Copy link
Member

@CodiumAI-Agent /review

@CodiumAI-Agent
Copy link

CodiumAI-Agent commented Sep 26, 2024 •
edited
Loading

PR Reviewer Guide 🔍

(Review updated until commit 1ab1ba8)

⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Key issues to review

Possible Bug
The useSystemTheme hook is used inside a useEffect which might lead to unexpected behavior or memory leaks if not handled properly. Consider reviewing the lifecycle and cleanup logic related to theme switching.

Code Smell
The useTheme hook might cause unnecessary re-renders or state updates due to its current setup in handling theme changes. Review the dependencies of the useEffect and ensure it's optimized for performance.

@reggie-k
Copy link
Member

✅ Preview Environment deployed on Bunnyshell

Component Endpoints
argocd https://argocd-5hxsdn.bunnyenv.com/
argocd-ttyd https://argocd-web-cli-5hxsdn.bunnyenv.com/
See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🔴 /bns:stop to stop the environment
  • 🚀 /bns:deploy to redeploy the environment
  • ❌ /bns:delete to remove the environment

/bns:deploy

@CodiumAI-Agent
Copy link

Persistent review updated to latest commit 1ab1ba8

reggie-k
reggie-k reviewed Sep 26, 2024
View reviewed changes
Copy link
Member

@reggie-k reggie-k left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the change locally and it looks really good!
I wonder whether we should change the default preference to 'auto' though or leave it light as it was.
Also, PTAL at the Codium AI review, this is also an opportunity to test how accurate it is.
And could you change the title of the to PR feat(ui) from feat(theme)?

@linghaoSu linghaoSu changed the title feat(theme): support auto theme feat(ui): support auto theme Sep 26, 2024
@linghaoSu
Copy link
Contributor Author

@reggie-k Thanks for your review!

I've changed the title.

Maybe it would be better to set the default theme to ‘light’.

codiumAI

  1. useSystemTheme is just used to register a listener to watch for changes in the OS theme and destroy the listener when the component is destroyed, that's why I used this feature in useEffect.
  2. for useTheme, it does need to be optimised, now it only watches the system theme change when the theme is auto. And fixed the issue with themeWrapper not using the preferred theme.

todaywasawesome
todaywasawesome approved these changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@todaywasawesome todaywasawesome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would be fine with auto being the default but I don't think it's that important and not worth stalling the merge.

This was referenced Sep 26, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@todaywasawesome todaywasawesome todaywasawesome approved these changes

@reggie-k reggie-k reggie-k approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Theme support auto mode
4 participants
@linghaoSu @reggie-k @CodiumAI-Agent @todaywasawesome