Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: warnings from golangci-lint: S1009 should omit nil check; non-constant format string in call to fmt.Errorf #849

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

chengfang
Copy link
Collaborator

No description provided.

…nstant format string in call to fmt.Errorf

Signed-off-by: Cheng Fang <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 73.46%. Comparing base (8c9e269) to head (3f75025).

Files with missing lines Patch % Lines
pkg/log/log.go 83.33% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #849   +/-   ##
=======================================
  Coverage   73.46%   73.46%           
=======================================
  Files          31       31           
  Lines        3128     3128           
=======================================
  Hits         2298     2298           
  Misses        694      694           
  Partials      136      136           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jannfis jannfis merged commit 40f260a into argoproj-labs:master Aug 30, 2024
10 checks passed
Tchoupinax pushed a commit to Tchoupinax/argocd-image-updater that referenced this pull request Oct 23, 2024
…nstant format string in call to fmt.Errorf (argoproj-labs#849)

Signed-off-by: Cheng Fang <[email protected]>
Signed-off-by: Tchoupinax <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants