Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Multiple aliases for the same image only 1 parameter is updated #846

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

chengfang
Copy link
Collaborator

Fixes #809

For multiple aliases pointing to the same image, parameters for each alias should be updated according to the application annotations. The test is contributed by dshmelev.

@codecov-commenter
Copy link

codecov-commenter commented Aug 30, 2024

Codecov Report

Attention: Patch coverage is 72.72727% with 3 lines in your changes missing coverage. Please review.

Project coverage is 73.43%. Comparing base (8c9e269) to head (5edd5ca).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
pkg/argocd/argocd.go 72.72% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #846      +/-   ##
==========================================
- Coverage   73.46%   73.43%   -0.03%     
==========================================
  Files          31       31              
  Lines        3128     3136       +8     
==========================================
+ Hits         2298     2303       +5     
- Misses        694      695       +1     
- Partials      136      138       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks.

@jannfis jannfis changed the title Multiple aliases for the same image only 1 parameter is updated fix: Multiple aliases for the same image only 1 parameter is updated Aug 30, 2024
@jannfis jannfis merged commit b2d8375 into argoproj-labs:master Aug 30, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple alias updates doesn't work (Write back method: git, Write back method: helmvalues)
3 participants