Add e2e tests for apps in any namespace feature #844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ishita Sequeira <[email protected]>
ishitasequeira
requested review from
jannfis,
chengfang and
pasha-codefresh
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #844 +/- ##
==========================================
+ Coverage 73.47% 73.48% +0.01%
==========================================
Files 31 31
Lines 3114 3142 +28
==========================================
+ Hits 2288 2309 +21
- Misses 692 695 +3
- Partials 134 138 +4 ☔ View full report in Codecov by Sentry. |
chengfang
reviewed
Aug 28, 2024
Signed-off-by: Ishita Sequeira <[email protected]>
chengfang
reviewed
Aug 28, 2024
chengfang
reviewed
Aug 28, 2024
chengfang
reviewed
Aug 28, 2024
Signed-off-by: Ishita Sequeira <[email protected]>
Signed-off-by: Ishita Sequeira <[email protected]>
Signed-off-by: Ishita Sequeira <[email protected]>
jannfis
approved these changes
Sep 6, 2024
Signed-off-by: Ishita Sequeira <[email protected]>
|
@jannfis @chengfang We would need the PR #854 to be merged in. I tested the e2e test with the code changes in the PR and it works successfully. I will check with the contributor to fix the unit tests in the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add e2e tests for apps in any namespace feature