Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Kustomize skip commit if nothing changed #607

Conversation

Fs02
Copy link
Contributor

@Fs02 Fs02 commented Aug 16, 2023

Related: #371

  • If a change to manifest is not synced, image updater will keep trying to update the image and try to produce a commit without any changes, this is resulting in error log and metrics which is noisy
  • This PR will skip commit for kustomization file when nothing is changed. this case can happen when the manifest in git is not synced

@Fs02 Fs02 force-pushed the fix/kustomize-skip-commit-if-nothing-changed branch from 038d700 to 0c425c3 Compare August 16, 2023 08:26
@Fs02 Fs02 force-pushed the fix/kustomize-skip-commit-if-nothing-changed branch from 0e28558 to 13691a5 Compare August 30, 2023 23:15
@lukaszsurfer
Copy link

👋 It looks like a year has passed and the problem is still active, the merge is welcome 😄

@chengfang
Copy link
Collaborator

@lukaszsurfer thanks for bringing that up. Will take a look.

@codecov-commenter
Copy link

codecov-commenter commented Sep 20, 2024

Codecov Report

Attention: Patch coverage is 52.94118% with 8 lines in your changes missing coverage. Please review.

Project coverage is 75.53%. Comparing base (13f01ec) to head (49c6542).

Files with missing lines Patch % Lines
pkg/argocd/git.go 52.94% 5 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #607      +/-   ##
==========================================
+ Coverage   75.47%   75.53%   +0.05%     
==========================================
  Files          31       31              
  Lines        3144     3151       +7     
==========================================
+ Hits         2373     2380       +7     
  Misses        636      636              
  Partials      135      135              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chengfang
Copy link
Collaborator

chengfang commented Sep 20, 2024

I resolved the conflict and moved some code, and can you all please take another look?

@chengfang chengfang force-pushed the fix/kustomize-skip-commit-if-nothing-changed branch 2 times, most recently from 440e030 to 737f9fb Compare September 20, 2024 03:46
@chengfang chengfang force-pushed the fix/kustomize-skip-commit-if-nothing-changed branch from 737f9fb to 49c6542 Compare September 20, 2024 15:04
@chengfang chengfang merged commit 5403b3e into argoproj-labs:master Sep 20, 2024
10 checks passed
Tchoupinax pushed a commit to Tchoupinax/argocd-image-updater that referenced this pull request Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants