Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default semver constraint for empty string #552

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

zywillc
Copy link

@zywillc zywillc commented Apr 11, 2023

This PR is to fix 2 issues:

  1. current tags filtering behavior will skip semver constraint for prereleases versions (although they are valid semver versions) when there is no explicit constraint parsed from image tags (i.e. empty string) which is inconsistent with the document description.
    https://github.com/argoproj-labs/argocd-image-updater/blob/master/pkg/image/version.go#L135-L147

  2. some complex prerelease constraint rules are actually not supported untilsemver > 3.2.0

@codecov-commenter
Copy link

codecov-commenter commented Apr 11, 2023

Codecov Report

Merging #552 (4c26a37) into master (49825ec) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #552      +/-   ##
==========================================
+ Coverage   65.76%   65.80%   +0.03%     
==========================================
  Files          21       21              
  Lines        2039     2041       +2     
==========================================
+ Hits         1341     1343       +2     
  Misses        569      569              
  Partials      129      129              
Impacted Files Coverage Δ
pkg/tag/tag.go 82.53% <ø> (ø)
pkg/image/version.go 42.04% <100.00%> (+1.34%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@zywillc zywillc force-pushed the default-semver-constraint branch 3 times, most recently from c642847 to 4c26a37 Compare April 11, 2023 17:43
Signed-off-by: Zeyuan Cao <[email protected]>
Signed-off-by: Zeyuan Cao <[email protected]>
Copy link
Contributor

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution and apologies that it took so long to come back to this PR.

Would you mind to rebase this PR (some of the lint changes have already been merged through another PR), and to supply a unit test for the * case?

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants