fix: remove ensure wallet in argent mobile and argent webwallet #126
Conversation
…ctors when request is invoked
bluecco
requested review from
mluisbrown,
Inukares,
Cussone,
kamilargent and
vladutjs
| @@ -56,18 +56,19 @@ export class ArgentMobileBaseConnector extends Connector { | |||
| } | |||
|
|
|||
| async ready(): Promise<boolean> { | |||
| // check if session is valid and retrieve the wallet | |||
| // if no sessions, it will show the login modal | |||
| await this.ensureWallet() | |||
There was a problem hiding this comment.
Without this code the _wallet property will not be initialized unless connect is called - will this be good enough? I wonder if the ensureWallet method shouldn't still initialize the _wallet property but not try to call enable
There was a problem hiding this comment.
Without this code the _wallet property will not be initialized unless connect is called - will this be good enough?
yes, it follows the same behaviour as webwallet
- if the wallet is not initialized, the dapp would display a
connectbutton - if the dapp has an autoconnect function, it will be initialized
if the dapp perform the request while not connected, it will receive the exception that will be managed on dapp side (like showing the connect modal)
managing ensureWallet without enable could be a little tricky at the moment, but can be a good point to improve in a future release
There was a problem hiding this comment.
Sounds good to me - just wanted to make sure it won't break our normal flows 👍
Issue / feature description
Remove argent mobile and argent webwallet popups when a request is performed (just throw an exception and the dapp will have to manage it)
required for being compatible with starknet-react, since it will always make a request while checking if the connector is connected (and, in this case, it shouldn't open mobile popup login / webwallet)
Changes
this.ensureWallet()for Argent Mobile connectorthis.ensureWallet()for Argent Webwallet connectorChecklist
Please keep your pull request as small as possible. If you need to make multiple changes, please create separate pull requests for each change. Create a draft pull request if you need early feedback. This will mark the pull request as a work in progress and prevent it from being reviewed or merged until you are ready.
Please move drafts to the ready for review (regular PR) when you are ready to start the review process and other developers will pick it up from there.