Merge pull request #46 from argentlabs/BLO-1894

fix: argent mobile connector icon url parameter
argentlabs · Dec 13, 2023 · f600baa · f600baa
2 parents 292292c + 5b2717b
commit f600baa
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/src/connectors/argentMobile/index.ts b/src/connectors/argentMobile/index.ts
@@ -25,6 +25,7 @@ export interface ArgentMobileConnectorOptions {
   chainId?: constants.NetworkName
   description?: string
   url?: string
+  icons?: string[]
 }
 
 export class ArgentMobileConnector extends Connector {
@@ -143,13 +144,15 @@ export class ArgentMobileConnector extends Connector {
 
   private async ensureWallet(): Promise<void> {
     const { getStarknetWindowObject } = await import("./modal")
-    const { chainId, projectId, dappName, description, url } = this._options
+    const { chainId, projectId, dappName, description, url, icons } =
+      this._options
     const options = {
       chainId: chainId ?? constants.NetworkName.SN_MAIN,
       name: dappName,
       projectId: projectId ?? DEFAULT_PROJECT_ID,
       description,
       url,
+      icons,
     }
 
     if (projectId === DEFAULT_PROJECT_ID) {

diff --git a/src/connectors/argentMobile/modal/login.ts b/src/connectors/argentMobile/modal/login.ts
@@ -15,6 +15,7 @@ export interface IArgentLoginOptions {
   name?: string
   description?: string
   url?: string
+  icons?: string[]
   chainId?: string | number
   rpcUrl?: string
   bridgeUrl?: string
@@ -34,6 +35,7 @@ export const login = async <TAdapter extends NamespaceAdapter>(
     mobileUrl = getMobileUrl(chainId),
     modalType = "overlay",
     url,
+    icons,
     walletConnect,
   }: IArgentLoginOptions,
   Adapter: new (options: NamespaceAdapterOptions) => TAdapter,
@@ -55,7 +57,7 @@ export const login = async <TAdapter extends NamespaceAdapter>(
       name: name ?? "Unknown dapp",
       description: description ?? "Unknown dapp description",
       url: url ?? "#",
-      icons: ["https://walletconnect.com/walletconnect-logo.png"],
+      icons: icons ?? [],
       ...walletConnect?.metadata,
     },
   }