Skip to content

Commit

Permalink
Merge branch 'develop' into feat/iframes-chrome-allowed-dapps
Browse files Browse the repository at this point in the history
* develop: (48 commits)
  chore(release): 2.1.1 [skip ci]
  fix: webwallet connector connect method
  chore(release): 2.1.0 [skip ci]
  chore: add sepolia support for injected connectors
  fix: starknet_signTypedData and starknet_addInvokeTransaction
  feat: starknetjs v6
  chore(release): 2.0.1 [skip ci]
  fix: starknet_supportedSpecs for argent mobile
  chore(release): 2.0.0 [skip ci]
  feat: adapt starknetKit to new JSON-rpc wallet api
  chore: refactor mobile adapter
  fix: argent mobile connector to work with new json rpc api
  chore(release): 1.1.4 [skip ci]
  fix: show installed wallets before not installed wallets
  fix: remove last wallet when user rejects with neverAsk mode
  chore: remove providers from more places
  chore: update connectors
  feat: update mobile connector
  fix: update webwallet connector
  fix: update connector interface
  ...
  • Loading branch information
bluecco committed Mar 19, 2024
2 parents 5c5c20c + 9518dfb commit 4c73a9e
Show file tree
Hide file tree
Showing 31 changed files with 1,601 additions and 690 deletions.
74 changes: 74 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,74 @@
# Starknetkit Contribution Guide

Thank you for investing your time in contributing to Starknetkit!

We love pull requests and this guide aims to provide an overview of the contribution workflow to help us make the contribution process effective for everyone involved.

If you want to contribute but don’t know what to do, take a look at issues labelled `good first issue`.

## Getting started

You can contribute to this repo in many ways:

- Solve open issues
- Report bugs or feature requests
- Add new features such as new connectors
- Improve the documentation

Contributions are made via Issues and Pull Requests (PRs). A few general guidelines for contributions:

- Search for existing Issues and PRs before creating your own.
- If you're running into an error, please give context. Explain what you're trying to do and how to reproduce the error.
- Please use the same formatting in the code repository. You can configure your IDE to do it by using the prettier / linting config files included in each package.
- If applicable, please edit the README.md file to reflect the changes.

### Issues

Issues should be used to report problems, request a new feature, or discuss potential changes before a PR is created.

#### Solve an issue

Scan through our existing issues to find one that interests you.

If a contributor is working on the issue, they will be assigned to the individual. If you find an issue to work on, you are welcome to assign it to yourself and open a PR with a fix for it.

### Pull Requests

#### Pull Request Process

We follow the ["fork-and-pull" Git workflow](https://github.com/susam/gitpr)

1. Fork the repo
2. Clone the project
3. Create a new branch with a descriptive name
4. Commit your changes to the new branch
5. Push changes to your fork
6. Open a PR in our repository and tag one of the maintainers to review your PR

Here are some tips for a high-quality pull request:

- Create a title for the PR that accurately defines the work done.
- Structure the description neatly to make it easy to consume by the readers. For example, you can include bullet points and screenshots instead of having one large paragraph.
- Add the link to the issue if applicable.
- Have a good commit message that summarises the work done.

Once you submit your PR:

- We may ask questions, request additional information or ask for changes to be made before a PR can be merged. Please note that these are to make the PR clear for everyone involved and aims to create a frictionless interaction process.
- As you update your PR and apply changes, mark each conversation resolved.
- Once approved, your PR will be merged.

#### Pull request targets

For the most common pull requests such as bug fixes, feature additions, documentation changes, etc., target the develop branch.

### Other notes

- If you have commit access to the repository and want to make a big change or are unsure about something, make a new branch and open a pull request.
- We’re using Prettier to format code, so don’t worry much about code formatting.
- Don’t commit generated files, like minified JavaScript.
- Don’t change the version number or changelog.

### Need help?

If you want to contribute but have any questions, concerns or doubts, feel free to ping maintainers. Ideally create a pull request with WIP (Work in progress) in its title and ask questions in the pull request description.
17 changes: 9 additions & 8 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "starknetkit",
"version": "1.0.25",
"version": "2.1.1",
"repository": "github:argentlabs/starknetkit",
"private": false,
"browser": {
Expand Down Expand Up @@ -57,12 +57,13 @@
"dependencies": {
"@trpc/client": "^10.38.1",
"@trpc/server": "^10.38.1",
"@walletconnect/sign-client": "^2.10.1",
"@walletconnect/sign-client": "^2.11.0",
"bowser": "^2.11.0",
"detect-browser": "^5.3.0",
"eventemitter3": "^5.0.1",
"events": "^3.3.0",
"get-starknet-core": "^3.1.0",
"get-starknet-core": "4.0.0-next.2",
"get-starknet-coreV3": "npm:[email protected]",
"lodash-es": "^4.17.21",
"svelte-forms": "^2.3.1",
"trpc-browser": "^1.3.2"
Expand All @@ -77,11 +78,11 @@
"@types/lodash-es": "^4.17.8",
"@types/node": "^20.5.7",
"@typescript-eslint/eslint-plugin": "^6.5.0",
"@walletconnect/ethereum-provider": "^2.7.7",
"@walletconnect/ethereum-provider": "^2.11.0",
"@walletconnect/jsonrpc-provider": "^1.0.13",
"@walletconnect/signer-connection": "^2.7.7",
"@walletconnect/types": "^2.7.7",
"@walletconnect/utils": "^2.10.0",
"@walletconnect/signer-connection": "^2.11.0",
"@walletconnect/types": "^2.11.0",
"@walletconnect/utils": "^2.11.0",
"autoprefixer": "^10.4.7",
"eslint": "^8.48.0",
"eslint-config-next": "^13.4.19",
Expand All @@ -104,7 +105,7 @@
"zod": "^3.20.6"
},
"peerDependencies": {
"starknet": "^5.24.3"
"starknet": "^6.1.3"
},
"gitHead": "b16688a8638cc138938e74e1a39d004760165d75"
}
Loading

0 comments on commit 4c73a9e

Please sign in to comment.