Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable mm support #11

Merged
merged 4 commits into from
Dec 4, 2024
Merged

Conversation

khanti42
Copy link
Contributor

@khanti42 khanti42 commented Dec 2, 2024

Issue / feature description

Adds support for MetaMask

Screen.Recording.2024-12-02.at.21.40.56.mov

Changes

  • updates pnpm-lock to target get-starknet 4.0.4 which enables MetaMask support.
  • uses GetStarknet function to load the virtual wallet in the window object.
  • injects MetaMask in the provider.

Checklist

  • Rebased to the last commit of the target branch (or merged)
  • Code self-reviewed
  • Code self-tested
  • Tests updated (if needed)
  • All tests are passing locally

Please keep your pull request as small as possible. If you need to make multiple changes, please create separate pull requests for each change. Create a draft pull request if you need early feedback. This will mark the pull request as a work in progress and prevent it from being reviewed or merged until you are ready.

Please move drafts to the ready for review (regular PR) when you are ready to start the review process and other developers will pick it up from there.

Copy link

vercel bot commented Dec 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
demo-dapp-starknet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 4, 2024 10:16am

@bluecco bluecco merged commit f1d816b into argentlabs:develop Dec 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants