Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update deployments.txt #64

Merged
merged 3 commits into from
Jul 22, 2024
Merged

update deployments.txt #64

merged 3 commits into from
Jul 22, 2024

Conversation

gaetbout
Copy link
Contributor

Just deploying all to sepolia + mainnet

@gaetbout gaetbout requested review from Leonard-Pat and sgc-code July 17, 2024 09:24
deployments.txt Outdated
GiftFactory address: 0x7e0f5a5364e197200461a18d695082848b3d4d1e90d3349492263f4c913ae3c
EscrowAccount class hash: 0x4e2ac27f56cf97077cf43788c831acdc8734e447a5ec676e93101b9dd22eace
EscrowLibrary class hash: 0x4ee1fc3650c515e0c30705c326dbda34a07ebe32bddf39be43b5110dd4ead16
GiftFactory classhash: 0x7fc7e4c4ec573895f7ea4a332c3bc4a3ddcc91604d53956dcc060b7eb9d0813
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they need an official address, classhash only relevant to keep track of the updates

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wdym?
You want me to deploy a contract factory?
Since there is now an owner (and I guess it needs to be tested at some point) I assume they could do it using ArgentX deploying tool (or voyager's)

Copy link
Contributor

@sgc-code sgc-code Jul 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's usually deployed by us, like on unframed, also because this file should include the official factory as a reference

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be good

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you deploy to mainnet too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the owner be the founder's wallet?

@gaetbout gaetbout requested a review from sgc-code July 19, 2024 08:48
@gaetbout
Copy link
Contributor Author

Please double check owner is correct on mainnet at least

@gaetbout
Copy link
Contributor Author

Pinging for review @sgc-code @Leonard-Pat

Copy link
Contributor

@sgc-code sgc-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sgc-code sgc-code merged commit 4ab474c into develop Jul 22, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants