More restrictions on validation #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaetbout
reviewed
Jul 4, 2024
Co-authored-by: gaetbout <[email protected]>
gaetbout
approved these changes
Jul 4, 2024
Leonard-Pat
approved these changes
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We prefer to be more cautious and add more restrictions to the transactions accepted by the account.
tx_info.paymaster_data: today, this field is always empty, as paymasters are not implemented yet on Starknet. But we are worried that later it might break the contract logic, as we are not fully convinced that the token used for the fee on v3 will always be STRK.tx_info.account_deployment_data, to ensure correctness, and because we have no motivation to allow different values, we are asserting it's also empty