Deployed all contracts to sepolia #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaetbout
reviewed
Jun 28, 2024
gaetbout
reviewed
Jun 28, 2024
deployments.txt
Outdated
|
|
||
| GiftFactory classhash: 0x6240992fd28e14bf2757a2b7320831220ffa7816cf962403b13f94aec95d7da | ||
| GiftFactory address: 0x7e0f5a5364e197200461a18d695082848b3d4d1e90d3349492263f4c913ae3c | ||
| GiftFactory owner: 0x6b054e8dbc5756e3f43b70cf1bfa4639c560898a3c70b2f753ba53bef549a1c |
There was a problem hiding this comment.
We can get this info from calling owner() on the factory, not sure it is relevant
There was a problem hiding this comment.
just wanted to add it so we have it all on one place, sometimes its useful to know which owner owns which deployment at a glance - but can remove :)
There was a problem hiding this comment.
i dont have a strong preference but i'm more inclined to remove it, beacause when we add more versions / networks to the file it will be too much info. Also it will get outdated, while addresses and classhashes wont
gaetbout
approved these changes
Jul 1, 2024
sgc-code
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.