Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scripts for admin functionality #40

Merged
merged 10 commits into from
Jul 1, 2024
Merged

Scripts for admin functionality #40

merged 10 commits into from
Jul 1, 2024

Conversation

Leonard-Pat
Copy link
Contributor

  • Added, claim_dust, upgrade and pause scripts

gaetbout
gaetbout reviewed Jun 24, 2024
View reviewed changes
scripts/claim-dust.ts Outdated Show resolved Hide resolved
@gaetbout
Copy link
Contributor

Woopsie, I won't review yet, my bad :D

@Leonard-Pat Leonard-Pat marked this pull request as draft June 25, 2024 08:59
@Leonard-Pat Leonard-Pat marked this pull request as ready for review June 28, 2024 14:56
@Leonard-Pat Leonard-Pat requested review from gaetbout and sgc-code June 28, 2024 14:56
sgc-code
sgc-code reviewed Jul 1, 2024
View reviewed changes
scripts/propose-upgrade.ts Outdated

logTransactionJson([tx]);

console.log("Proposed upgrade will be ready at: ", date);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice detail

gaetbout
gaetbout reviewed Jul 1, 2024
View reviewed changes
Copy link
Contributor

@gaetbout gaetbout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File name are mixing casing

gaetbout
gaetbout reviewed Jul 1, 2024
View reviewed changes
scripts/claim-dust.ts Outdated
}

const tx = executeActionOnAccount(
"get_dust",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

get_dust doesn't exist anymore

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops good spot

gaetbout
gaetbout reviewed Jul 1, 2024
View reviewed changes
scripts/claim-dust.ts Outdated Show resolved Hide resolved
gaetbout
gaetbout approved these changes Jul 1, 2024
View reviewed changes
Copy link
Contributor

@gaetbout gaetbout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just quickly update claim-dust.ts

@Leonard-Pat
Copy link
Contributor Author

File name are mixing casing

should i do snake case or camel case ?

@gaetbout
Copy link
Contributor

gaetbout commented Jul 1, 2024

should i do snake case or camel case ?

Would just align to the most used one atm, unless there is a TS specific "rule"

@Leonard-Pat
Copy link
Contributor Author

should i do snake case or camel case ?

Would just align to the most used one atm, unless there is a TS specific "rule"

okay made them snake since we have that for other files

@sgc-code sgc-code merged commit eca7529 into develop Jul 1, 2024
5 checks passed
@sgc-code sgc-code deleted the feat/admin-scripts branch July 5, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaetbout gaetbout gaetbout approved these changes

@sgc-code sgc-code sgc-code approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Leonard-Pat @gaetbout @sgc-code