Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add setup claim function for ts-tests #2

Merged
merged 35 commits into from
Jun 10, 2024
Merged

Add setup claim function for ts-tests #2

merged 35 commits into from
Jun 10, 2024

Conversation

Leonard-Pat
Copy link
Contributor

  • Refactor integration tests to have a setup function
  • Avoids restarting and clearing devnet / redeclaring all contracts (much quicker)

@Leonard-Pat Leonard-Pat requested review from sgc-code and gaetbout June 5, 2024 15:45
@Leonard-Pat Leonard-Pat marked this pull request as draft June 5, 2024 15:48
@Leonard-Pat Leonard-Pat marked this pull request as ready for review June 5, 2024 16:23
@Leonard-Pat Leonard-Pat requested a review from sgc-code June 6, 2024 09:28
@gaetbout
Copy link
Contributor

gaetbout commented Jun 6, 2024 •
edited
Loading

Big TY for making the lib folder lighter 🙏

@Leonard-Pat
Copy link
Contributor Author

Big TY for making the lib folder lighter 🙏

okay removed even more now , im sure we can delete more but maybe its good enough for now

sgc-code
sgc-code reviewed Jun 6, 2024
View reviewed changes
lib/claim.ts Outdated Show resolved Hide resolved
sgc-code
sgc-code reviewed Jun 6, 2024
View reviewed changes
lib/claim.ts Outdated Show resolved Hide resolved
sgc-code
sgc-code reviewed Jun 6, 2024
View reviewed changes
lib/claim.ts Outdated Show resolved Hide resolved
sgc-code
sgc-code reviewed Jun 6, 2024
View reviewed changes
lib/deposit.ts Outdated Show resolved Hide resolved
sgc-code
sgc-code reviewed Jun 6, 2024
View reviewed changes
lib/deposit.ts Outdated Show resolved Hide resolved
sgc-code
sgc-code reviewed Jun 6, 2024
View reviewed changes
lib/claim.ts Show resolved Hide resolved
sgc-code
sgc-code reviewed Jun 6, 2024
View reviewed changes
lib/deposit.ts Outdated Show resolved Hide resolved
sgc-code
sgc-code reviewed Jun 6, 2024
View reviewed changes
lib/deposit.ts Outdated Show resolved Hide resolved
gaetbout
gaetbout reviewed Jun 7, 2024
View reviewed changes
lib/claim.ts Outdated Show resolved Hide resolved
gaetbout
gaetbout reviewed Jun 7, 2024
View reviewed changes
lib/claim.ts Outdated Show resolved Hide resolved
@Leonard-Pat Leonard-Pat requested review from sgc-code and gaetbout June 7, 2024 15:49
sgc-code
sgc-code approved these changes Jun 7, 2024
View reviewed changes
Copy link
Contributor

@sgc-code sgc-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice job! there are some issues but we can iterate later after merged

@Leonard-Pat Leonard-Pat mentioned this pull request Jun 10, 2024
Merged
@gaetbout gaetbout merged commit 50517c0 into develop Jun 10, 2024
5 checks passed
@sgc-code sgc-code deleted the refactor/ts-tests branch July 5, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgc-code sgc-code sgc-code approved these changes

@gaetbout gaetbout Awaiting requested review from gaetbout

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Leonard-Pat @gaetbout @sgc-code