-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add curl option #13
base: master
Are you sure you want to change the base?
Add curl option #13
Commits on Aug 4, 2024
-
Put class declaration into header file.
Also change the DRIVER_MODIFICATION number even though I'm not sure if this should be done since this shouldn't change anything in the driver per se.
marcofilho committedAug 4, 2024 Configuration menu - View commit details
-
Copy full SHA for 76d2f02 - Browse repository at this point
Copy the full SHA 76d2f02View commit details -
Style: remove invisible ^L characters
marcofilho committedAug 4, 2024 Configuration menu - View commit details
-
Copy full SHA for 44d4952 - Browse repository at this point
Copy the full SHA 44d4952View commit details
Commits on Aug 7, 2024
-
Add curl compilation and runtime option
Add WITH_CURL compilation option. If compiled with WITH_CURL = YES, CurlUsage.template file will be added and it's records will be created. curl.h will be included. First record - UseCurl - should futurely toggle curl usage in the Driver.
marcofilho committedAug 7, 2024 Configuration menu - View commit details
-
Copy full SHA for 73fbdce - Browse repository at this point
Copy the full SHA 73fbdceView commit details -
Add curl initialization option.
marcofilho committedAug 7, 2024 Configuration menu - View commit details
-
Copy full SHA for e11a8bf - Browse repository at this point
Copy the full SHA e11a8bfView commit details -
Add record to set CURLOPT_HTTPAUTH
marcofilho committedAug 7, 2024 Configuration menu - View commit details
-
Copy full SHA for 377795a - Browse repository at this point
Copy the full SHA 377795aView commit details -
Add record to set CURLOPT_SSL_VERIFYHOST
marcofilho committedAug 7, 2024 Configuration menu - View commit details
-
Copy full SHA for 39d9b34 - Browse repository at this point
Copy the full SHA 39d9b34View commit details -
Add record for setting CURLOPT_SSL_VERIFYPEER
marcofilho committedAug 7, 2024 Configuration menu - View commit details
-
Copy full SHA for 702fc78 - Browse repository at this point
Copy the full SHA 702fc78View commit details -
Get rid of unnecessary itemp variable.
No need to use getIntegerParam in this context if we already have the value argument.
marcofilho committedAug 7, 2024 Configuration menu - View commit details
-
Copy full SHA for 308d666 - Browse repository at this point
Copy the full SHA 308d666View commit details -
Add record to set CURLOPT_USERNAME (beware)
Using this along with to-be-added CURLOPT_PASSWORD would expose credentials in the network. I leave it in the driver as a means to completely express the API functionalities, but there should be better ways of setting your credentials if you mean to. Probably will add a configuration file for that in the future.
marcofilho committedAug 7, 2024 Configuration menu - View commit details
-
Copy full SHA for 2906040 - Browse repository at this point
Copy the full SHA 2906040View commit details -
Add record for setting CURLOPT_PASSWORD (beware)
Same warning about last commit: this shouldn't be used but it's left here as an option for quick testing and better expressing the API functionalities. For actual credentials usage future records should add a path for a configuration file containing the credentials.
marcofilho committedAug 7, 2024 Configuration menu - View commit details
-
Copy full SHA for 0176dc2 - Browse repository at this point
Copy the full SHA 0176dc2View commit details
Commits on Aug 11, 2024
-
Add records to set config filepath
Should be used to load the file contents and put them into the correct parameters. Uses a very similar mechanism from NDFile.template and functions from asynNDArrayDriver. For now it just checks if the file exists and is accessible, but not it's contents.
marcofilho committedAug 11, 2024 Configuration menu - View commit details
-
Copy full SHA for 78d9c2c - Browse repository at this point
Copy the full SHA 78d9c2cView commit details
Commits on Aug 18, 2024
-
Add curl file loading functionality
Add CurlLoadConfig record and loadConfigFile function. loadConfigFile() calls writeInt32 and writeOctet for all parameters it can recognize, except username and password. For those, loadConfigFile() calls curl_easy_setopt without ever setting the parameter value. This means setpoint and RBV values for all parameters can be different, so I add readback values for all records. writeInt32 and writeOctet are called inside loadConfigFile(), which is called inside writeInt32. In my understanding this cannot lead to any infinite loop since CurlLoadConfig record has no "ASYN_" prepending it's name, so it's impossible for it to call writeInt32 on itself. Also, I think this is thread safe because the function is only supposed to be called inside writeInt32, which is supposed to be already locked.
marcofilho committedAug 18, 2024 Configuration menu - View commit details
-
Copy full SHA for b9ca193 - Browse repository at this point
Copy the full SHA b9ca193View commit details
Commits on Aug 21, 2024
-
Add writeCallback and buffer. Use it on readImage.
Readbuffer is a char vector just so we can copy all needed bytes to it. writeCallback should simply add stuff to the buffer. readImage clears buffer before adding to it. Unfortunately I think clear cant be called inside writeCallback because it's called more than one time per read.
marcofilho committedAug 21, 2024 Configuration menu - View commit details
-
Copy full SHA for 116434e - Browse repository at this point
Copy the full SHA 116434eView commit details -
Fix: add needed set of CURLOPT_URL
This is obviously needed and acquisition will fail without this.
marcofilho committedAug 21, 2024 Configuration menu - View commit details
-
Copy full SHA for 404f5dc - Browse repository at this point
Copy the full SHA 404f5dcView commit details -
Style: remove trailing whitespaces.
marcofilho committedAug 21, 2024 Configuration menu - View commit details
-
Copy full SHA for 8cff152 - Browse repository at this point
Copy the full SHA 8cff152View commit details -
Merge branch 'add-config-file' into add-curl-option
marcofilho committedAug 21, 2024 Configuration menu - View commit details
-
Copy full SHA for d11dec2 - Browse repository at this point
Copy the full SHA d11dec2View commit details -
Add WITH_CURL example in CONFIG_SITE
WITH_CURL = YES/NO is used to tell the compiler to use or not use curl. I add an example in configure/CONFIG_SITE to make it easy for people to enable/disable this in future.
marcofilho committedAug 21, 2024 Configuration menu - View commit details
-
Copy full SHA for de4f1ad - Browse repository at this point
Copy the full SHA de4f1adView commit details -
Merge branch 'add-curl-option'
Curl is added as an option both at compile and at runtime. If compiled with WITH_CURL = YES at configure/CONFIG_SITE.local, curl option will be enabled at runtime but default will still be UseCurl = NO. If record $(P)$(R)UseCurl = YES, then code will get image from URL using libCurl instead of graphicsMagick. Some curlOptions are configurable as records. More can be easily added. The CurlConfigFile.template is based on NDFile.template, but a bit different, so I preferred to create a new one instead of including the one that already exists. Maybe this can be modified in future.
marcofilho committedAug 21, 2024 Configuration menu - View commit details
-
Copy full SHA for 32681b4 - Browse repository at this point
Copy the full SHA 32681b4View commit details
Commits on Aug 22, 2024
-
Add driver description in ADURL.rst
Describe all new records along with brief driver description.
marcofilho committedAug 22, 2024 Configuration menu - View commit details
-
Copy full SHA for b55dc74 - Browse repository at this point
Copy the full SHA b55dc74View commit details -
Add comments in st_base example file
Comments to make it easier to load Curl template file if compiled with WITH_CURL=YES
marcofilho committedAug 22, 2024 Configuration menu - View commit details
-
Copy full SHA for 1208fb1 - Browse repository at this point
Copy the full SHA 1208fb1View commit details -
marcofilho committed
Aug 22, 2024 Configuration menu - View commit details
-
Copy full SHA for 2aec6fd - Browse repository at this point
Copy the full SHA 2aec6fdView commit details -
Merge branch 'documentation' into add-curl-option
marcofilho committedAug 22, 2024 Configuration menu - View commit details
-
Copy full SHA for 01698b2 - Browse repository at this point
Copy the full SHA 01698b2View commit details -
Merge branch 'add-curl-option'
Add records and driver description into ADURL.rst and code comments in each function.
marcofilho committedAug 22, 2024 Configuration menu - View commit details
-
Copy full SHA for 1b1c03f - Browse repository at this point
Copy the full SHA 1b1c03fView commit details
Commits on Aug 23, 2024
-
Change driver modification/revision numbers
Since this PR is supposed to add new functionality, I reset patch number and add to revision number.
marcofilho committedAug 23, 2024 Configuration menu - View commit details
-
Copy full SHA for dbe0454 - Browse repository at this point
Copy the full SHA dbe0454View commit details -
Update RELEASE with curl modifications
Update with info about header file change and curl functionality added.
marcofilho committedAug 23, 2024 Configuration menu - View commit details
-
Copy full SHA for af80cc7 - Browse repository at this point
Copy the full SHA af80cc7View commit details -
Merge branch 'doc' into add-curl-option
marcofilho committedAug 23, 2024 Configuration menu - View commit details
-
Copy full SHA for 992a83d - Browse repository at this point
Copy the full SHA 992a83dView commit details -
Merge branch 'add-curl-option'
Post merge of doc branch into add-curl-option.
marcofilho committedAug 23, 2024 Configuration menu - View commit details
-
Copy full SHA for 74aa1a6 - Browse repository at this point
Copy the full SHA 74aa1a6View commit details