Expose armv7 build in the package_index.json #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alessio-perugini
added
the
type: imperfection
|
The only thing that I'm not sure is the host value. |
per1234
added
os: linux
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're building for armv7 but we're not publishing that in our package_index.json.
The uno r4 plugin is built with CGO, not publishing the armv7 binary will fallback on the armv6 one which won't run even on armv7 due to dynamically linked stuff.
To allow fw-uploader to take armv7 builds we have to give a unique name in the
hostkey in the package_json template and handle such cases in: https://github.com/arduino/arduino-cli/blob/df12786440c1078957734aa1686a38c86afcda84/arduino/cores/tools.go#L151