Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude OPTA_* from unor4 package #365

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Conversation

pennam
Copy link
Contributor

@pennam pennam commented Aug 19, 2024

I suspect OPTA folder should be excluded from uno r4 package

@pennam pennam requested review from maidnl and facchinm August 19, 2024 15:16
@per1234 per1234 added type: imperfection Perceived defect in any part of project topic: infrastructure Related to project infrastructure labels Aug 19, 2024
@facchinm
Copy link
Member

Indeed, but should also be excluded from the uno_r4 package 🤔 The hacky solution would be to also add .uno_r4_only but it's not very explicit (nor nice)

@pennam
Copy link
Contributor Author

pennam commented Sep 17, 2024

the .unor4_only flag is already in place. so the OPTA variant in excluded from portenta package and included in uno r4. Adding also .portenta_only would exclude the opta varian to be included for both.

@pennam pennam merged commit b91d211 into arduino:main Oct 2, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: infrastructure Related to project infrastructure type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants