fixup! added possibility to get fw version of wifi module as uint32

arduino · Nov 21, 2024 · 483a3b8 · 483a3b8
1 parent 8942cff
commit 483a3b8
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/libraries/WiFiS3/src/WiFi.cpp b/libraries/WiFiS3/src/WiFi.cpp
@@ -22,16 +22,21 @@ const char* CWifi::firmwareVersion() {
    return "99.99.99";
 }
 
+/*
+ * Since version is made in a semver fashion, thus in an integer it will be represented as
+ *  byte 1 (MSB) | byte 2 | byte 3 | byte 4
+ *             0 | MAJOR  | MINOR  | PATCH
+ */
 /* -------------------------------------------------------------------------- */
 uint32_t CWifi::firmwareVersionU32() {
 /* -------------------------------------------------------------------------- */
    uint8_t ret[4];
    string res = "";
    modem.begin();
    if(modem.write(string(PROMPT(_FWVERSION_U32)), res, CMD_READ(_FWVERSION_U32))) {
-      return res[0] << 24| res[1] << 16 | res[2] << 8 | res[3];
+      return res[0] << 16| res[1] << 8 | res[2];
    }
-   return 0x63636300;
+   return 0x636363;
 }
 
 /* -------------------------------------------------------------------------- */