Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ESP8266 ESP32 compatible #70

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

ESP8266 ESP32 compatible #70

wants to merge 10 commits into from

Conversation

mostafahk
Copy link

No description provided.

@CLAassistant
Copy link

CLAassistant commented Aug 30, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@mostafahk
Copy link
Author

This would works if my merge in ArduinoRS485 accepted.

@github-actions
Copy link

Memory usage change @ cd2120b

Board flash % RAM for global variables %
arduino:avr:leonardo 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:mbed:envie_m7 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:mbed:nano33ble 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:megaavr:uno2018:mode=off 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:mkrwifi1010 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
Click for full report table
Board examples/RTU/ModbusRTUClientKitchenSink
flash		 % examples/RTU/ModbusRTUClientKitchenSink
RAM for global variables		 % examples/RTU/ModbusRTUClientToggle
flash		 % examples/RTU/ModbusRTUClientToggle
RAM for global variables		 % examples/RTU/ModbusRTUServerKitchenSink
flash		 % examples/RTU/ModbusRTUServerKitchenSink
RAM for global variables		 % examples/RTU/ModbusRTUServerLED
flash		 % examples/RTU/ModbusRTUServerLED
RAM for global variables		 % examples/RTU/ModbusRTUTemperatureSensor
flash		 % examples/RTU/ModbusRTUTemperatureSensor
RAM for global variables		 % examples/TCP/EthernetModbusClientToggle
flash		 % examples/TCP/EthernetModbusClientToggle
RAM for global variables		 % examples/TCP/EthernetModbusServerLED
flash		 % examples/TCP/EthernetModbusServerLED
RAM for global variables		 % examples/TCP/WiFiModbusClientToggle
flash		 % examples/TCP/WiFiModbusClientToggle
RAM for global variables		 % examples/TCP/WiFiModbusServerLED
flash		 % examples/TCP/WiFiModbusServerLED
RAM for global variables		 %
arduino:avr:leonardo 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:mbed:envie_m7 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:mbed:nano33ble 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:megaavr:uno2018:mode=off 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:samd:mkrwifi1010 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
Click for full report CSV 
Board,examples/RTU/ModbusRTUClientKitchenSink<br>flash,%,examples/RTU/ModbusRTUClientKitchenSink<br>RAM for global variables,%,examples/RTU/ModbusRTUClientToggle<br>flash,%,examples/RTU/ModbusRTUClientToggle<br>RAM for global variables,%,examples/RTU/ModbusRTUServerKitchenSink<br>flash,%,examples/RTU/ModbusRTUServerKitchenSink<br>RAM for global variables,%,examples/RTU/ModbusRTUServerLED<br>flash,%,examples/RTU/ModbusRTUServerLED<br>RAM for global variables,%,examples/RTU/ModbusRTUTemperatureSensor<br>flash,%,examples/RTU/ModbusRTUTemperatureSensor<br>RAM for global variables,%,examples/TCP/EthernetModbusClientToggle<br>flash,%,examples/TCP/EthernetModbusClientToggle<br>RAM for global variables,%,examples/TCP/EthernetModbusServerLED<br>flash,%,examples/TCP/EthernetModbusServerLED<br>RAM for global variables,%,examples/TCP/WiFiModbusClientToggle<br>flash,%,examples/TCP/WiFiModbusClientToggle<br>RAM for global variables,%,examples/TCP/WiFiModbusServerLED<br>flash,%,examples/TCP/WiFiModbusServerLED<br>RAM for global variables,%
arduino:avr:leonardo,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:mbed:envie_m7,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,,,,,,,,
arduino:mbed:nano33ble,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,,,,,,,,
arduino:megaavr:uno2018:mode=off,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:mkrwifi1010,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0

@PeeJay
Copy link

PeeJay commented Nov 14, 2021

#include <HardwareSerial.h> needs to be included in ModbusRTUServer.cpp and ModbusRTUClient.cpp otherwise

In file included from .pio\libdeps\esp8266\ArduinoModbus\src\ModbusRTUClient.cpp:23:
.pio\libdeps\esp8266\ArduinoModbus\src\libmodbus/modbus.h:64:33: error: 'SerialConfig' has not been declared
   64 |     #define RS485_SER_CONF_TYPE SerialConfig

@github-actions
Copy link

Memory usage change @ a8e852e

Board flash % RAM for global variables %
arduino:avr:leonardo 🔺 +104 - +112 +0.36 - +0.39 🔺 +39 - +39 +1.52 - +1.52
arduino:mbed:envie_m7 🔺 +80 - +144 +0.01 - +0.02 🔺 +56 - +64 +0.01 - +0.01
arduino:mbed:nano33ble 🔺 +152 - +152 +0.02 - +0.02 🔺 +64 - +72 +0.02 - +0.03
arduino:megaavr:uno2018:mode=off 🔺 +104 - +104 +0.21 - +0.21 🔺 +31 - +31 +0.5 - +0.5
arduino:samd:mkrwifi1010 🔺 +128 - +152 +0.05 - +0.06 🔺 +60 - +76 +0.18 - +0.23
Click for full report table
Board examples/RTU/ModbusRTUClientKitchenSink
flash		 % examples/RTU/ModbusRTUClientKitchenSink
RAM for global variables		 % examples/RTU/ModbusRTUClientToggle
flash		 % examples/RTU/ModbusRTUClientToggle
RAM for global variables		 % examples/RTU/ModbusRTUServerKitchenSink
flash		 % examples/RTU/ModbusRTUServerKitchenSink
RAM for global variables		 % examples/RTU/ModbusRTUServerLED
flash		 % examples/RTU/ModbusRTUServerLED
RAM for global variables		 % examples/RTU/ModbusRTUTemperatureSensor
flash		 % examples/RTU/ModbusRTUTemperatureSensor
RAM for global variables		 % examples/TCP/EthernetModbusClientToggle
flash		 % examples/TCP/EthernetModbusClientToggle
RAM for global variables		 % examples/TCP/EthernetModbusServerLED
flash		 % examples/TCP/EthernetModbusServerLED
RAM for global variables		 % examples/TCP/WiFiModbusClientToggle
flash		 % examples/TCP/WiFiModbusClientToggle
RAM for global variables		 % examples/TCP/WiFiModbusServerLED
flash		 % examples/TCP/WiFiModbusServerLED
RAM for global variables		 %
arduino:avr:leonardo 104 0.36 39 1.52 104 0.36 39 1.52 104 0.36 39 1.52 104 0.36 39 1.52 104 0.36 39 1.52 104 0.36 39 1.52 112 0.39 39 1.52
arduino:mbed:envie_m7 80 0.01 64 0.01 80 0.01 56 0.01 144 0.02 56 0.01 144 0.02 56 0.01 80 0.01 56 0.01
arduino:mbed:nano33ble 152 0.02 64 0.02 152 0.02 72 0.03 152 0.02 72 0.03 152 0.02 72 0.03 152 0.02 72 0.03
arduino:megaavr:uno2018:mode=off 104 0.21 31 0.5 104 0.21 31 0.5 104 0.21 31 0.5 104 0.21 31 0.5 104 0.21 31 0.5 104 0.21 31 0.5 104 0.21 31 0.5 104 0.21 31 0.5 104 0.21 31 0.5
arduino:samd:mkrwifi1010 128 0.05 60 0.18 128 0.05 60 0.18 136 0.05 60 0.18 128 0.05 60 0.18 128 0.05 60 0.18 152 0.06 76 0.23 144 0.05 76 0.23 128 0.05 60 0.18 136 0.05 60 0.18
Click for full report CSV 
Board,examples/RTU/ModbusRTUClientKitchenSink<br>flash,%,examples/RTU/ModbusRTUClientKitchenSink<br>RAM for global variables,%,examples/RTU/ModbusRTUClientToggle<br>flash,%,examples/RTU/ModbusRTUClientToggle<br>RAM for global variables,%,examples/RTU/ModbusRTUServerKitchenSink<br>flash,%,examples/RTU/ModbusRTUServerKitchenSink<br>RAM for global variables,%,examples/RTU/ModbusRTUServerLED<br>flash,%,examples/RTU/ModbusRTUServerLED<br>RAM for global variables,%,examples/RTU/ModbusRTUTemperatureSensor<br>flash,%,examples/RTU/ModbusRTUTemperatureSensor<br>RAM for global variables,%,examples/TCP/EthernetModbusClientToggle<br>flash,%,examples/TCP/EthernetModbusClientToggle<br>RAM for global variables,%,examples/TCP/EthernetModbusServerLED<br>flash,%,examples/TCP/EthernetModbusServerLED<br>RAM for global variables,%,examples/TCP/WiFiModbusClientToggle<br>flash,%,examples/TCP/WiFiModbusClientToggle<br>RAM for global variables,%,examples/TCP/WiFiModbusServerLED<br>flash,%,examples/TCP/WiFiModbusServerLED<br>RAM for global variables,%
arduino:avr:leonardo,104,0.36,39,1.52,104,0.36,39,1.52,104,0.36,39,1.52,104,0.36,39,1.52,104,0.36,39,1.52,104,0.36,39,1.52,112,0.39,39,1.52
arduino:mbed:envie_m7,80,0.01,64,0.01,80,0.01,56,0.01,144,0.02,56,0.01,144,0.02,56,0.01,80,0.01,56,0.01,,,,,,,,
arduino:mbed:nano33ble,152,0.02,64,0.02,152,0.02,72,0.03,152,0.02,72,0.03,152,0.02,72,0.03,152,0.02,72,0.03,,,,,,,,
arduino:megaavr:uno2018:mode=off,104,0.21,31,0.5,104,0.21,31,0.5,104,0.21,31,0.5,104,0.21,31,0.5,104,0.21,31,0.5,104,0.21,31,0.5,104,0.21,31,0.5,104,0.21,31,0.5,104,0.21,31,0.5
arduino:samd:mkrwifi1010,128,0.05,60,0.18,128,0.05,60,0.18,136,0.05,60,0.18,128,0.05,60,0.18,128,0.05,60,0.18,152,0.06,76,0.23,144,0.05,76,0.23,128,0.05,60,0.18,136,0.05,60,0.18

@OptifySudarshanPatil
Copy link

Retry check to ignore AVR memory issue thanks to #106 to ease merge.

1 similar comment
@OptifySudarshanPatil

This comment was marked as duplicate.

Sign in to view
@nikito7 nikito7 mentioned this pull request Sep 22, 2023
Open
@nikito7
Copy link

nikito7 commented Sep 27, 2023

Don't work with esp8266

@per1234 per1234 added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mostafahk @CLAassistant @PeeJay @OptifySudarshanPatil @nikito7 @per1234