-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Url parser #173
Added Url parser #173
Conversation
Memory usage change @ a1a79a5
Click for full report table
Click for full report CSV
|
Memory usage change @ 734f5b5
Click for full report table
Click for full report CSV
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please put the externally maintained code in a dedicated folder (e.g., src/utility/URLParser
. This will facilitate updates and maintenance. With the current approach of putting the files in a general purpose utility
folder, it is likely to get mixed with various other files that are either bespoke or else from other external sources.
Please add a README.md
file to the folder that documents the upstream source in order to facilitate updates and allow bug fixes and feature requests to be directed to the appropriate project.
0c68451
to
9ea6ace
Compare
Memory usage change @ 9ea6ace
Click for full report table
Click for full report CSV
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @andreagilardoni!
No description provided.