Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue #245 - ATT_OP_FIND_INFO_RESP incorrect processing durin… #263

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

carterd
Copy link

@carterd carterd commented Sep 25, 2022

Fix for issue #245 - ATT_OP_FIND_INFO_RESP incorrect processing during ATTClass::discoverDescriptors causes crashing

I've highlighted this issue on 9th July ... this is an issue of causing CRASHES if using ArduinoBLE to connect as central and the response to ATT_OP_FIND_INFO_RESP includes 128-bit UUIDs.

Please check and remove comments after review

@CLAassistant
Copy link

CLAassistant commented Sep 25, 2022

CLA assistant check
All committers have signed the CLA.

… processing during ATTClass::discoverDescriptors causes crashing

I've highlighted this issue on 9th July ... this is an issue of causing __CRASHES__ if using ArduinoBLE to connect as central and the response to ATT_OP_FIND_INFO_RESP includes 128-bit UUIDs.
@per1234 per1234 added type: imperfection Perceived defect in any part of project topic: code Related to content of the project itself labels Sep 25, 2022
@facchinm
Copy link
Contributor

Hi @carterd ,
thanks for looking into this! I think the PR can be simplified a bit, I'm adding some inline comments. Will be more than happy to merge afterwards 😉

src/utility/ATT.cpp Show resolved Hide resolved
Copy link
Author

@carterd carterd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jeez missed this ... looks fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants