449: Support JSON serialization of ushort SmartEnums #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ardalis fix is complete, but looks like After those are resolved this should build and work. |
|
Yeah I turned on warnings as errors yesterday but somehow those didn't immediately appear... |
|
Had to build in release mode locally to get the XML comment warnings... |
|
Ok, @sdepouw can you have a look at the branch fixing-errors and see if you can knock some more out? I got most of them... |
|
@ardalis think this one's good to go |
|
Thanks! |
sdepouw
deleted the
sdepouw/449-ushort-support-systemtextjson-serialization
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ushortSmartEnumtypes are now supported inSystem.Text.Jsonwriting/serialization