Add netstandard2.0 support (#531)

* feat: Build in netstandard2.0 to support .Net Framework * docs: Update version description
ardalis · Jun 28, 2024 · 219cc1b · 219cc1b
1 parent c3f8e56
commit 219cc1b
Show file tree

Hide file tree

Showing 5 changed files with 21 additions and 18 deletions.
diff --git a/Directory.Build.props b/Directory.Build.props
@@ -9,7 +9,7 @@
 		<PackageProjectUrl>https://github.com/ardalis/SmartEnum</PackageProjectUrl>
 		<PublishRepositoryUrl>true</PublishRepositoryUrl>
 		<PackageLicenseExpression>MIT</PackageLicenseExpression>
-		<TargetFrameworks>net7.0;net6.0;net8.0;netstandard2.1</TargetFrameworks>
+		<TargetFrameworks>net7.0;net6.0;net8.0;netstandard2.0</TargetFrameworks>
 		<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
 		<AutoGenerateBindingRedirects>true</AutoGenerateBindingRedirects>
 		<Version>8.0.0</Version>
@@ -35,4 +35,4 @@
       up $(IsStableBuild) automatically; property is also used to control prerelease branding.
     -->
 	</PropertyGroup>
-</Project>
+</Project>
diff --git a/README.md b/README.md
@@ -89,13 +89,7 @@ Install-Package Ardalis.SmartEnum.Dapper
 
 ## Version
 
-The latest version of the package supports .NET 7. If you don't need or aren't yet ready to move to .NET 7 or later, you should install the previous stable version, [Ardalis.SmartEnum 2.1](https://www.nuget.org/packages/Ardalis.SmartEnum/2.1.0).
-
-Example package manager command:
-
-```
-Install-Package Ardalis.SmartEnum -Version 2.1.0
-```
+The latest version of the package supports .NET 8 and NetStandard 2.0.
 
 ## Usage
 

diff --git a/benchmarks/SmartEnum.Benchmarks/FromNameBenchmarks.cs b/benchmarks/SmartEnum.Benchmarks/FromNameBenchmarks.cs
@@ -12,18 +12,27 @@ public class FromNameBenchmarks
         ////////////////////////////////////////////////////////////////////////////////
         // Enum
 
+        private static TestEnum ParseTestEnum(string value, bool ignoreCase = false)
+        {
+            #if NETSTANDARD2_0
+                return (TestEnum)Enum.Parse(typeof(TestEnum), value, ignoreCase);
+            #else
+                return Enum.Parse<TestEnum>(value, ignoreCase);
+            #endif
+        }
+
         [Benchmark]
-        public TestEnum Enum_FromName_One() => Enum.Parse<TestEnum>("One");
+        public TestEnum Enum_FromName_One() => ParseTestEnum("One");
 
         [Benchmark]
-        public TestEnum Enum_FromName_Ten() => Enum.Parse<TestEnum>("Ten");
+        public TestEnum Enum_FromName_Ten() => ParseTestEnum("Ten");
 
         [Benchmark]
         public TestEnum Enum_FromName_Invalid()
         {
             try
             {
-                return Enum.Parse<TestEnum>("Invalid");
+                return ParseTestEnum("Invalid");
             }
             catch (Exception)
             {
@@ -32,18 +41,18 @@ public TestEnum Enum_FromName_Invalid()
         }
 
         [Benchmark]
-        public TestEnum Enum_FromName_one_IgnoreCase() => Enum.Parse<TestEnum>("one", true);
+        public TestEnum Enum_FromName_one_IgnoreCase() => ParseTestEnum("one", true);
 
         [Benchmark]
-        public TestEnum Enum_FromName_ten_IgnoreCase() => Enum.Parse<TestEnum>("ten", true);
+        public TestEnum Enum_FromName_ten_IgnoreCase() => ParseTestEnum("ten", true);
 
 
         [Benchmark]
         public TestEnum Enum_FromName_Invalid_IgnoreCase()
         {
             try
             {
-                return Enum.Parse<TestEnum>("Invalid", true);
+                return ParseTestEnum("Invalid", true);
             }
             catch (Exception)
             {
@@ -229,4 +238,4 @@ public TestSmartEnum SmartEnum_TryFromName_Invalid_IgnoreCase()
         }
 
     }
-}
+}
diff --git a/src/SmartEnum.SystemTextJson/SmartEnum.SystemTextJson.csproj b/src/SmartEnum.SystemTextJson/SmartEnum.SystemTextJson.csproj
@@ -14,7 +14,7 @@
     <PropertyGroup Condition=" '$(Configuration)' == 'Release' ">
         <DocumentationFile>bin\$(Configuration)\$(TargetFramework)\$(AssemblyName).xml</DocumentationFile>
     </PropertyGroup>
-    <ItemGroup Condition="'$(TargetFramework)' == 'netStandard2.1'">
+    <ItemGroup Condition="'$(TargetFramework)' == 'netStandard2.0'">
         <PackageReference Include="System.Text.Json" />
     </ItemGroup>
     <ItemGroup>

diff --git a/src/SmartEnum/SmartEnum.csproj b/src/SmartEnum/SmartEnum.csproj
@@ -34,7 +34,7 @@
 		</None>
 		<None Include="$(SolutionDir)img\icon.png" Pack="true" Visible="false" PackagePath="" />
 	</ItemGroup>
-	<ItemGroup Condition="'$(TargetFramework)' == 'netStandard2.1'">
+	<ItemGroup Condition="'$(TargetFramework)' == 'netStandard2.0'">
 	  <PackageReference Include="System.ComponentModel.Annotations" />
 	</ItemGroup>
 </Project>