Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prettier #55

Merged
merged 3 commits into from
Jun 22, 2019
Merged

Prettier #55

merged 3 commits into from
Jun 22, 2019

Conversation

arcticicestudio
Copy link
Owner

@arcticicestudio arcticicestudio commented Jun 22, 2019 •
edited
Loading

Resolves #37

@arcticicestudio
Install prettier
fc70c6e 
Installed the main `prettier` (1) NPM package.

References:
  (1) npmjs.com/package/prettier

Epic: GH-33
Depends on GH-47 GH-49
GH-37
@arcticicestudio
Implement Prettier configuration and ignore pattern file
d8eefc0 
This is one of the main features of Prettier: It already provides the
best and recommended style configurations of-out-the-box.
The only option that has been changed is the print width (1). It is set
to `80` by default which not up-to-date for modern screens (might only
be relevant when working in terminals only like e.g. with Vim). It is
now set to `120` used by all of Arctic Ice Studio's style guides.
The `prettier.config.js` configuration file is placed in the project
root as well as the `.prettierignore` file that defines ignore pattern.

References:
  (1) prettier.io/docs/en/options.html#print-width

Epic: GH-33
Depends on GH-47 GH-49
GH-37
@arcticicestudio
Implement NPM format:pretty script/task for Prettier
87bfb7d 
To allow to format all sources the `format:pretty` NPM script/task has
been added as well as the `format` script/task to run all tasks of the
formatting workflow.

Epic: GH-33
Depends on GH-47 GH-49
Resolves GH-37
@arcticicestudio arcticicestudio self-assigned this Jun 22, 2019
@arcticicestudio arcticicestudio modified the milestones: 0.3.0, 0.4.0 Jun 22, 2019
@arcticicestudio arcticicestudio merged commit be3e59a into epic/gh-33-the-way-to-go Jun 22, 2019
@arcticicestudio arcticicestudio deleted the feature/gh-37-prettier branch June 22, 2019 19:17
@arcticicestudio arcticicestudio removed their assignment Jun 22, 2019
@arcticicestudio arcticicestudio mentioned this pull request Jun 22, 2019
Closed
5 tasks
@arcticicestudio arcticicestudio mentioned this pull request Jun 23, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svengreb svengreb svengreb approved these changes

Assignees
No one assigned
Labels
context-workflow scope-maintainability type-feature
Projects
None yet
Milestone
0.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@arcticicestudio @svengreb