Add MIME type for CSV files #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add MIME type for comma-separated value files and use the UTF-8 charset: "text/csv; charset=utf-8" At the moment, they appear as type: "application/octet-stream" ...which is the default type for unknown files. This should fix the CSV file created by archmap. Currently, when you open it in a browser some of the text is incorrectly formatted. References: * https://archwomen.org/media/archmap/archmap.csv * https://www.iana.org/assignments/media-types/text/csv
|
I got confused with the plain text file here ( #6 ) and actually haven't run into any problems with the text formatting in the CSV file. Firefox and Chromium both just download the file and on my iPhone the table is displayed properly, without errors. Can't hurt to have it reported as the right thing though 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add MIME type for comma-separated value files and use the UTF-8 charset:
text/csv; charset=utf-8At the moment, they appear as type:
application/octet-stream...which is the default type for unknown files.
This should fix the CSV file created by archmap.
Currently, when you open it in a browser some of
the text is incorrectly formatted.
References: