Netx 184 clear stuck packets when there is a success event seen #35
reviewdog [GolangCI Lint] report
reported by reviewdog 🐶
Findings (40)
pkg/collector/ibc_collector.go|215 col 2| unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
pkg/collector/ibc_collector.go|218| File is not gofumpt
-ed with -extra
(gofumpt)
pkg/collector/ibc_collector.go|238 col 3| ineffectual assignment to newAckHeight (ineffassign)
pkg/collector/ibc_collector.go|240| File is not gofumpt
-ed with -extra
(gofumpt)
pkg/collector/ibc_collector.go|249 col 4| assignments should only be cuddled with other assignments (wsl)
pkg/collector/ibc_collector.go|252 col 2| block should not end with a whitespace (or comment) (wsl)
pkg/collector/ibc_collector.go|255 col 3| ineffectual assignment to newAckHeight (ineffassign)
pkg/collector/ibc_collector.go|257| File is not gofumpt
-ed with -extra
(gofumpt)
pkg/collector/ibc_collector.go|314 col 3| commentFormatting: put a space between //
and comment text (gocritic)
pkg/collector/ibc_collector.go|325 col 4| assignments should only be cuddled with other assignments (wsl)
pkg/collector/ibc_collector.go|332 col 3| ineffectual assignment to newAckHeight (ineffassign)
pkg/collector/ibc_collector.go|334| File is not gofumpt
-ed with -extra
(gofumpt)
pkg/ibc/ibc.go|204 col 2| expressions should not be cuddled with declarations or returns (wsl)
pkg/ibc/ibc.go|205 col 2| only one cuddle assignment allowed before go statement (wsl)
pkg/ibc/ibc.go|207 col 3| declarations should never be cuddled (wsl)
pkg/ibc/ibc.go|211 col 3| if statements should only be cuddled with assignments (wsl)
pkg/ibc/ibc.go|239 col 4| return statements should not be cuddled if block has more than two lines (wsl)
pkg/ibc/ibc.go|249 col 3| declarations should never be cuddled (wsl)
pkg/ibc/ibc.go|253 col 3| if statements should only be cuddled with assignments (wsl)
pkg/ibc/ibc.go|280 col 4| return statements should not be cuddled if block has more than two lines (wsl)
pkg/ibc/ibc.go|290| File is not gofumpt
-ed with -extra
(gofumpt)
pkg/ibc/ibc.go|296 col 3| go statements can only invoke functions assigned on line above (wsl)
pkg/ibc/ibc.go|326 col 3| go statements can only invoke functions assigned on line above (wsl)
pkg/ibc/ibc.go|350 col 5| return statements should not be cuddled if block has more than two lines (wsl)
pkg/ibc/ibc.go|354 col 2| expressions should not be cuddled with blocks (wsl)
pkg/ibc/ibc.go|360 col 3| return statements should not be cuddled if block has more than two lines (wsl)
pkg/ibc/ibc.go|367 col 3| go statements can only invoke functions assigned on line above (wsl)
pkg/ibc/ibc.go|369 col 4| assignments should only be cuddled with other assignments (wsl)
pkg/ibc/ibc.go|370 col 4| only one cuddle assignment allowed before if statement (wsl)
pkg/ibc/ibc.go|377 col 5| return statements should not be cuddled if block has more than two lines (wsl)
pkg/ibc/ibc.go|391 col 3| go statements can only invoke functions assigned on line above (wsl)
pkg/ibc/ibc.go|393 col 4| assignments should only be cuddled with other assignments (wsl)
pkg/ibc/ibc.go|394 col 4| only one cuddle assignment allowed before if statement (wsl)
pkg/ibc/ibc.go|401 col 5| return statements should not be cuddled if block has more than two lines (wsl)
pkg/ibc/ibc.go|412 col 2| expressions should not be cuddled with blocks (wsl)
pkg/ibc/ibc.go|417 col 83| unused-parameter: parameter 'newAckHeight' seems to be unused, consider removing or renaming it as _ (revive)
pkg/ibc/ibc.go|419 col 29| var-declaration: should omit type int64 from declaration of var lastQueriedBlockHeight; it will be inferred from the right-hand side (revive)
pkg/ibc/ibc.go|447| File is not gofumpt
-ed with -extra
(gofumpt)
pkg/ibc/ibc.go|464 col 5| assignOp: replace lastQueriedBlockHeight = lastQueriedBlockHeight + 1
with lastQueriedBlockHeight++
(gocritic)
pkg/ibc/ibc.go|465 col 5| only one cuddle assignment allowed before range statement (wsl)
Filtered Findings (3)
pkg/collector/ibc_collector.go|200| File is not gofumpt
-ed with -extra
(gofumpt)
pkg/config/config.go|207 col 4| only one cuddle assignment allowed before if statement (wsl)
pkg/ibc/ibc.go|176| File is not gofumpt
-ed with -extra
(gofumpt)
Annotations
Check failure on line 215 in pkg/collector/ibc_collector.go
github-actions / GolangCI Lint
[GolangCI Lint] pkg/collector/ibc_collector.go#L215
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
Raw output
pkg/collector/ibc_collector.go:215:2: unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
ctx context.Context,
^
Check failure on line 218 in pkg/collector/ibc_collector.go
github-actions / GolangCI Lint
[GolangCI Lint] pkg/collector/ibc_collector.go#L218
File is not `gofumpt`-ed with `-extra` (gofumpt)
Raw output
pkg/collector/ibc_collector.go:218: File is not `gofumpt`-ed with `-extra` (gofumpt)
metric chan<- prometheus.Metric) error {
Check failure on line 238 in pkg/collector/ibc_collector.go
github-actions / GolangCI Lint
[GolangCI Lint] pkg/collector/ibc_collector.go#L238
ineffectual assignment to newAckHeight (ineffassign)
Raw output
pkg/collector/ibc_collector.go:238:3: ineffectual assignment to newAckHeight (ineffassign)
newAckHeight = 0
^
Check failure on line 240 in pkg/collector/ibc_collector.go
github-actions / GolangCI Lint
[GolangCI Lint] pkg/collector/ibc_collector.go#L240
File is not `gofumpt`-ed with `-extra` (gofumpt)
Raw output
pkg/collector/ibc_collector.go:240: File is not `gofumpt`-ed with `-extra` (gofumpt)
//TODO:start scan for new Acks from start height
Check failure on line 249 in pkg/collector/ibc_collector.go
github-actions / GolangCI Lint
[GolangCI Lint] pkg/collector/ibc_collector.go#L249
assignments should only be cuddled with other assignments (wsl)
Raw output
pkg/collector/ibc_collector.go:249:4: assignments should only be cuddled with other assignments (wsl)
newAckHeight = 0
^
Check failure on line 252 in pkg/collector/ibc_collector.go
github-actions / GolangCI Lint
[GolangCI Lint] pkg/collector/ibc_collector.go#L252
block should not end with a whitespace (or comment) (wsl)
Raw output
pkg/collector/ibc_collector.go:252:2: block should not end with a whitespace (or comment) (wsl)
} else if _, ok := cc.AckProcessors[srcHashKey]; ok {
^
Check failure on line 255 in pkg/collector/ibc_collector.go
github-actions / GolangCI Lint
[GolangCI Lint] pkg/collector/ibc_collector.go#L255
ineffectual assignment to newAckHeight (ineffassign)
Raw output
pkg/collector/ibc_collector.go:255:3: ineffectual assignment to newAckHeight (ineffassign)
newAckHeight = 0
^
Check failure on line 257 in pkg/collector/ibc_collector.go
github-actions / GolangCI Lint
[GolangCI Lint] pkg/collector/ibc_collector.go#L257
File is not `gofumpt`-ed with `-extra` (gofumpt)
Raw output
pkg/collector/ibc_collector.go:257: File is not `gofumpt`-ed with `-extra` (gofumpt)
//TODO:start scan for new Acks from start height
Check failure on line 314 in pkg/collector/ibc_collector.go
github-actions / GolangCI Lint
[GolangCI Lint] pkg/collector/ibc_collector.go#L314
commentFormatting: put a space between `//` and comment text (gocritic)
Raw output
pkg/collector/ibc_collector.go:314:3: commentFormatting: put a space between `//` and comment text (gocritic)
//start scan for new Acks from start height
^
Check failure on line 325 in pkg/collector/ibc_collector.go
github-actions / GolangCI Lint
[GolangCI Lint] pkg/collector/ibc_collector.go#L325
assignments should only be cuddled with other assignments (wsl)
Raw output
pkg/collector/ibc_collector.go:325:4: assignments should only be cuddled with other assignments (wsl)
newAckHeight = 0
^
Check failure on line 332 in pkg/collector/ibc_collector.go
github-actions / GolangCI Lint
[GolangCI Lint] pkg/collector/ibc_collector.go#L332
ineffectual assignment to newAckHeight (ineffassign)
Raw output
pkg/collector/ibc_collector.go:332:3: ineffectual assignment to newAckHeight (ineffassign)
newAckHeight = 0
^
Check failure on line 334 in pkg/collector/ibc_collector.go
github-actions / GolangCI Lint
[GolangCI Lint] pkg/collector/ibc_collector.go#L334
File is not `gofumpt`-ed with `-extra` (gofumpt)
Raw output
pkg/collector/ibc_collector.go:334: File is not `gofumpt`-ed with `-extra` (gofumpt)
//TODO:start scan for new Acks from start height
Check failure on line 204 in pkg/ibc/ibc.go
github-actions / GolangCI Lint
[GolangCI Lint] pkg/ibc/ibc.go#L204
expressions should not be cuddled with declarations or returns (wsl)
Raw output
pkg/ibc/ibc.go:204:2: expressions should not be cuddled with declarations or returns (wsl)
wg.Add(2)
^
Check failure on line 205 in pkg/ibc/ibc.go
github-actions / GolangCI Lint
[GolangCI Lint] pkg/ibc/ibc.go#L205
only one cuddle assignment allowed before go statement (wsl)
Raw output
pkg/ibc/ibc.go:205:2: only one cuddle assignment allowed before go statement (wsl)
go func() {
^
Check failure on line 207 in pkg/ibc/ibc.go
github-actions / GolangCI Lint
[GolangCI Lint] pkg/ibc/ibc.go#L207
declarations should never be cuddled (wsl)
Raw output
pkg/ibc/ibc.go:207:3: declarations should never be cuddled (wsl)
var (
^
Check failure on line 211 in pkg/ibc/ibc.go
github-actions / GolangCI Lint
[GolangCI Lint] pkg/ibc/ibc.go#L211
if statements should only be cuddled with assignments (wsl)
Raw output
pkg/ibc/ibc.go:211:3: if statements should only be cuddled with assignments (wsl)
if err = retry.Do(func() error {
^
Check failure on line 239 in pkg/ibc/ibc.go
github-actions / GolangCI Lint
[GolangCI Lint] pkg/ibc/ibc.go#L239
return statements should not be cuddled if block has more than two lines (wsl)
Raw output
pkg/ibc/ibc.go:239:4: return statements should not be cuddled if block has more than two lines (wsl)
return
^
Check failure on line 249 in pkg/ibc/ibc.go
github-actions / GolangCI Lint
[GolangCI Lint] pkg/ibc/ibc.go#L249
declarations should never be cuddled (wsl)
Raw output
pkg/ibc/ibc.go:249:3: declarations should never be cuddled (wsl)
var (
^
Check failure on line 253 in pkg/ibc/ibc.go
github-actions / GolangCI Lint
[GolangCI Lint] pkg/ibc/ibc.go#L253
if statements should only be cuddled with assignments (wsl)
Raw output
pkg/ibc/ibc.go:253:3: if statements should only be cuddled with assignments (wsl)
if err = retry.Do(func() error {
^
Check failure on line 280 in pkg/ibc/ibc.go
github-actions / GolangCI Lint
[GolangCI Lint] pkg/ibc/ibc.go#L280
return statements should not be cuddled if block has more than two lines (wsl)
Raw output
pkg/ibc/ibc.go:280:4: return statements should not be cuddled if block has more than two lines (wsl)
return
^
Check failure on line 290 in pkg/ibc/ibc.go
github-actions / GolangCI Lint
[GolangCI Lint] pkg/ibc/ibc.go#L290
File is not `gofumpt`-ed with `-extra` (gofumpt)
Raw output
pkg/ibc/ibc.go:290: File is not `gofumpt`-ed with `-extra` (gofumpt)
var (
srcUnreceivedPackets, dstUnreceivedPackets []uint64
)
Check failure on line 296 in pkg/ibc/ibc.go
github-actions / GolangCI Lint
[GolangCI Lint] pkg/ibc/ibc.go#L296
go statements can only invoke functions assigned on line above (wsl)
Raw output
pkg/ibc/ibc.go:296:3: go statements can only invoke functions assigned on line above (wsl)
go func() {
^
Check failure on line 326 in pkg/ibc/ibc.go
github-actions / GolangCI Lint
[GolangCI Lint] pkg/ibc/ibc.go#L326
go statements can only invoke functions assigned on line above (wsl)
Raw output
pkg/ibc/ibc.go:326:3: go statements can only invoke functions assigned on line above (wsl)
go func() {
^
Check failure on line 350 in pkg/ibc/ibc.go
github-actions / GolangCI Lint
[GolangCI Lint] pkg/ibc/ibc.go#L350
return statements should not be cuddled if block has more than two lines (wsl)
Raw output
pkg/ibc/ibc.go:350:5: return statements should not be cuddled if block has more than two lines (wsl)
return
^
Check failure on line 354 in pkg/ibc/ibc.go
github-actions / GolangCI Lint
[GolangCI Lint] pkg/ibc/ibc.go#L354
expressions should not be cuddled with blocks (wsl)
Raw output
pkg/ibc/ibc.go:354:2: expressions should not be cuddled with blocks (wsl)
wg.Wait()
^