test: Fixing tests for the new econ #312
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
☠️ Closing cuz time based inflation RIP |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❗Do not merge until #311 is merged
Mostly changes in how the mint params are setup
❓In
txfees_test.go, our current minted tokens were more than the expected minted tokens. So the test was failing.archway/e2e/txfees_test.go
Line 69 in 1e2602f
Not sure where the previous expected value came from. So currently just replaced that value with a higher one which makes the test pass. But what should be the expected value? We need some simulated tokens amounts for default params set.