Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SharedPtr was not correctly handling destruction of the block. The allocator would be destructed alongside the compressed pair when the strong reference went to zero. Then it would attempt to free using the allocator it just destructed. This is a problem for stateful allocators as it may have internal state that is rendered invalid after destruction.
The fix is to only destruct the managed object when the strong reference goes to zero. Then, when the weak reference goes to zero, take a copy of the allocator and destruct the remaining parts (including the internal allocator). Then use the copied allocator to carry out the free.