Add support for Mockito/ByteBuddy requiring javaagent on Java 21

- See mockito/mockito#3037
- See mockito/mockito#3037 (comment)
- See https://javadoc.io/doc/org.mockito/mockito-core/latest/org/mockito/Mockito.html#0.3

- Need to add org.mockito dependency to testsupport plugin so that the path to the mockito jar is always resolved when using ${org.mockito:mockito-core:jar}

- To run JUnit in Eclipse you need to add the following VM arguments (adjust path version as required):

-Xshare:off
-javaagent:${workspace_loc}/.metadata/.plugins/org.eclipse.pde.core/.bundle_pool/plugins/org.mockito.mockito-core_5.14.2.jar

.github/workflows/tests.yml

@@ -14,7 +14,7 @@ jobs:
     - name: Set up Java
       uses: actions/setup-java@v4
       with:
-        java-version: '17'
+        java-version: '21'
         distribution: 'temurin'
         cache: 'maven'
 

com.archimatetool.editor.product/archi.target

@@ -10,8 +10,8 @@
         <unit id="org.eclipse.jgit.ssh.apache.feature.group" version="6.10.0.202406032230-r"/>
     </location>
     <location includeAllPlatforms="false" includeConfigurePhase="true" includeMode="planner" includeSource="true" type="InstallableUnit">
-        <repository location="https://download.eclipse.org/tools/orbit/simrel/orbit-aggregation/release/4.32.0"/>
-        <unit id="org.mockito.mockito-core" version="5.12.0"/>
+        <repository location="https://download.eclipse.org/tools/orbit/simrel/orbit-aggregation/2024-12"/>
+        <unit id="org.mockito.mockito-core" version="5.14.2"/>
     </location>
 </locations>
 </target>

tests/com.archimatetool.testsupport/META-INF/MANIFEST.MF

@@ -7,6 +7,7 @@ Bundle-Vendor: Archi
 Bundle-RequiredExecutionEnvironment: JavaSE-17
 Eclipse-BundleShape: dir
 Export-Package: com.archimatetool.tests
+Import-Package: org.mockito
 Require-Bundle: org.eclipse.core.runtime,
  org.eclipse.ui
 Bundle-ClassPath: .

tests/pom.xml

@@ -12,13 +12,34 @@
 
     <artifactId>com.archimatetool.testing</artifactId>
     <packaging>pom</packaging>
+
+    <properties>
+        <!-- Mockito/ByeBuddy needs this on Java 21+ -->
+        <mockito.args>-Xshare:off -javaagent:${org.mockito:mockito-core:jar}</mockito.args>
+        <!-- <tycho.testArgLine> is passed as <argLine> to tycho-surefire-plugin -->
+        <tycho.testArgLine>${mockito.args}</tycho.testArgLine>
+    </properties>
+
+    <profiles>
+        <profile>
+            <id>osx</id>
+            <activation>
+                <os>
+                    <family>mac</family>
+                </os>
+            </activation>
+            <properties>
+                <tycho.testArgLine>-XstartOnFirstThread ${mockito.args}</tycho.testArgLine>
+            </properties>
+        </profile>
+    </profiles>
 
     <!-- Orbit p2 repo provides Mockito and latest JUnit for tests -->
     <repositories>
         <repository>
             <id>Orbit</id>
             <layout>p2</layout>
-            <url>https://download.eclipse.org/tools/orbit/simrel/orbit-aggregation/release/4.32.0</url>
+            <url>https://download.eclipse.org/tools/orbit/simrel/orbit-aggregation/2024-12</url>
         </repository>
     </repositories>
 
@@ -43,6 +64,20 @@
 
     <build>
         <plugins>
+            <!-- Add this so we can resolve ${org.mockito:mockito-core:jar} -->
+            <plugin>
+                <groupId>org.apache.maven.plugins</groupId>
+                <artifactId>maven-dependency-plugin</artifactId>
+                <version>3.8.1</version>
+                <executions>
+                    <execution>
+                        <goals>
+                            <goal>properties</goal>
+                        </goals>
+                    </execution>
+                </executions>
+            </plugin>
+
             <plugin>
                 <groupId>org.eclipse.tycho</groupId>
                 <artifactId>tycho-surefire-plugin</artifactId>
@@ -56,30 +91,4 @@
             </plugin>
         </plugins>
     </build>
-
-    <profiles>
-        <profile>
-            <id>osx</id>
-            <activation>
-                <os>
-                    <family>mac</family>
-                </os>
-            </activation>
-            <build>
-                <pluginManagement>
-                    <plugins>
-                        <plugin>
-                            <groupId>org.eclipse.tycho</groupId>
-                            <artifactId>tycho-surefire-plugin</artifactId>
-                            <version>${tycho-version}</version>
-                            <configuration>
-                                <argLine>-XstartOnFirstThread</argLine>
-                            </configuration>
-                        </plugin>
-                    </plugins>
-                </pluginManagement>
-            </build>
-        </profile>
-    </profiles>
-
 </project>