Skip to content

Commit

Permalink
Don't flip splash screen image on macOS 14
Browse files Browse the repository at this point in the history
- Because this is (partially) fixed in Eclipse 4.30 we don't need to flip the image

- But this will only work for macOS 14 unless we target Eclipse 4.31 or later
  • Loading branch information
Phillipus committed Feb 14, 2024
1 parent 286af4a commit 55fd5eb
Showing 1 changed file with 7 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,13 @@ public void init(Shell shell) {
* See https://github.com/eclipse-platform/eclipse.platform.swt/issues/772
*/
private void checkMacBackgroundImageInverted(Shell shell) {
if(PlatformUtils.isMac() && PlatformUtils.compareOSVersion("14.0") >= 0) { //$NON-NLS-1$
// This was partially fixed for Eclipse 4.30 in org.eclipse.ui.internal.Workbench but that only checks for macOS 14
// So that fix won't work on macOS 15 and greater.
// https://github.com/eclipse-platform/eclipse.platform.ui/pull/1355/commits/884bb26a23374c5c1def95ca70b7abc74f395382
// However, there is a better macOS version check in Eclipse 4.31.
// So we'll compare with macOS 15.
// TODO: remove this if and when we target Eclipse 4.31 or greater
if(PlatformUtils.isMac() && PlatformUtils.compareOSVersion("15.0") >= 0) { //$NON-NLS-1$
// Flip the image
shell.setBackgroundImage(flipImage(shell.getDisplay(), shell.getBackgroundImage()));

Expand Down

0 comments on commit 55fd5eb

Please sign in to comment.