fix(tailwind): include colorMap.json in tailwind folder #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romiekos
approved these changes
Aug 11, 2023
romiekos
reviewed
Aug 11, 2023
CHANGELOG.md
Outdated
| ### Bug Fixes | ||
|
|
||
| * **tailwind:** include colorMap.json in tailwind folder ([3589503](https://github.com/archilogic-com/honeycomb/commit/3589503b00bd3775ff1161de60469f00ec86dbc1)) | ||
|
|
There was a problem hiding this comment.
The changelog is here because this is the test-preset-fix version?
"version": "2.5.1-test-preset-fix.1",
this format of versioning is new to me 🙂
tailwind/colorMap.json
Outdated
There was a problem hiding this comment.
I'm not sure I follow... The file is now in 2 places?
There was a problem hiding this comment.
yes, unfortunately. I'm looking for a better way but I wanted to fix the broken package in the meantime. Summary:
- the types have been broken for some time (I think since v2.2.0) as we are emitting the folder structure including
src. See the dist folder here - my fix in v2.5.0 was to use the
rootDiroption. The restriction is that all compiled files must be insiderootDir, hence movingcolorMap.jsonintosrc. - moving the
colorMapworked locally but caused an issue with the npm package, because the tailwind files are not compiled, and thesrcdirectory is not included in the distributed package 🤦♂️
There was a problem hiding this comment.
I created al-4728 to follow up
luk-zap
approved these changes
Aug 14, 2023
archilogic-ci
pushed a commit
that referenced
this pull request
Aug 14, 2023
## [2.5.1](v2.5.0...v2.5.1) (2023-08-14) ### Bug Fixes * **tailwind:** include colorMap.json in tailwind folder ([#71](#71)) ([6e23ea1](6e23ea1))
|
🎉 This PR is included in version 2.5.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick fix for the broken v2.5.0 build, which has issues due to the
tailwind-preset.cjsfile needing to be resolved at build-time. The issue only surfaces when installing via npm, because in that case thesrcfolder is excluded.