Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #1

Closed
wants to merge 2 commits into from
Closed

fixes #1

wants to merge 2 commits into from

Conversation

sticilface
Copy link

This adds the implementation for Syslog &Syslog::server(IPAddress ip, uint16_t port) which is missing.
adds a check to use _ip if _server is null
adds a new method to use PSTR() within Syslog & vlogf_P(uint16_t pri, PGM_P formatP, ...) this saves RAM and is quite cool.

@sticilface
Copy link
Author

I used this post to fix the vsnprintf_P on the other platform but can't test if it actually works
bportaluri/WiFiEsp#27

@arcao
Copy link
Owner

arcao commented Jan 30, 2017

This adds the implementation for Syslog &Syslog::server(IPAddress ip, uint16_t port) which is missing.
adds a check to use _ip if _server is null

I will fix it in version 2.1.0

adds a new method to use PSTR() within Syslog & vlogf_P(uint16_t pri, PGM_P formatP, ...) this saves RAM and is quite cool.

Yes, I've think about the same. I will definitely add it to version 2.1.0. But your implementation should be separated into two methods: logf_P(uint16_t pri, PGM_P formatP, ...) and vlogf_P(uint16_t pri, PGM_P formatP, va_list args). The v there means va_list.

@arcao
Copy link
Owner

arcao commented Feb 1, 2017

I made my own implementation of logf_P anyway thanks for PR.

@arcao arcao closed this Feb 1, 2017
@sticilface
Copy link
Author

no problem :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants