Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor discretization. #2415

Merged
merged 16 commits into from
Oct 18, 2024

Conversation

thorstenhater
Copy link
Contributor

@thorstenhater thorstenhater commented Sep 24, 2024

This PR rectifies a long-standing issue since the introduction of decor:
CV discretization was treated as a defaultable value instead of a cell property, along with bio-physical properties.

This lead to some awkward facts:

  • Intermingling of bio-physics and numerical settings
  • Discretization is treated like a default without override.
  • Discretization cannot be changed once set, e.g. if read from .acc, requiring the copy+update of a decor instead

Thus:

  • Discretization can now be set during cable_cell construction
  • It can be read and updated later
  • Refactor cv_policy to use type erasure like other, similar constructions, e.g. schedules.
  • Hide internal cv_policy constructors.

⚠️ Breaks .acc by upgrading from 0.9 to 0.10 ⚠️

Closes #1408

arbor/include/arbor/cv_policy.hpp Outdated Show resolved Hide resolved
arbor/cable_cell.cpp Show resolved Hide resolved
arbor/include/arbor/util/expected.hpp Show resolved Hide resolved
doc/python/cable_cell.rst Outdated Show resolved Hide resolved
arborio/cableio.cpp Outdated Show resolved Hide resolved
python/example/single_cell_bluepyopt_l5pc.py Outdated Show resolved Hide resolved
python/strprintf.hpp Show resolved Hide resolved
@thorstenhater thorstenhater merged commit 76120d1 into arbor-sim:master Oct 18, 2024
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move cv_policy out of cable_cell_parameter_set
2 participants