Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add debug print to flaky JSON test #2404

Merged
merged 2 commits into from
Sep 12, 2024
Merged

Add debug print to flaky JSON test #2404

merged 2 commits into from
Sep 12, 2024

Conversation

thorstenhater
Copy link
Contributor

Try to catch a flaky JSON test in CI.

boeschf
boeschf approved these changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@boeschf boeschf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finding this! Shouldn't CodeQL warn about stuff like this?

@thorstenhater
Copy link
Contributor Author

Clang-tidy and friends do warn about this, but no one had the stomach to sit down, work through all the warnings
deciding between fixing and ignoring them and make the setup part of Arbor. So far...
CodeQL doesn't seem to mind that particular issue.

@thorstenhater thorstenhater reopened this Sep 12, 2024
@thorstenhater thorstenhater merged commit b6ecfef into arbor-sim:master Sep 12, 2024
41 of 43 checks passed
@thorstenhater thorstenhater deleted the bug/flaky-json-test branch September 12, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boeschf boeschf boeschf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thorstenhater @boeschf