re-introduce updated CSCS CI #2402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cscs-ci run default |
|
Don't worry too much about Spack, something is wrong with their infrastructure... |
|
cscs-ci run |
1 similar comment
|
cscs-ci run |
|
cscs-ci run default |
1 similar comment
|
cscs-ci run default |
thorstenhater
requested changes
Sep 12, 2024
CMakeLists.txt
Outdated
| @@ -323,6 +323,7 @@ if (ARB_WITH_PYTHON) | |||
| endif() | |||
|
|
|||
| CPMAddPackage(NAME pugixml | |||
| FORCE TRUE | |||
There was a problem hiding this comment.
Why is that needed? Could pugi be provided by the OS/base layer?
There was a problem hiding this comment.
I reintroduced the system package, if available. Changed the install method for pyarb to use rpaths, however, for it to find pugixml.so when linked with a spack installed version, for example.
thorstenhater
approved these changes
Sep 13, 2024
| @@ -49,10 +49,20 @@ set_target_properties(pyarb PROPERTIES OUTPUT_NAME _arbor) | |||
| # arbor.cpython-36m-x86_64-linux-gnu.so | |||
| set_target_properties(pyarb PROPERTIES PREFIX "${PYTHON_MODULE_PREFIX}" SUFFIX "${PYTHON_MODULE_EXTENSION}") | |||
|
|
|||
| # Set RPATH for the installation phase | |||
| if(APPLE) | |||
There was a problem hiding this comment.
I am fine with that solution, although I was originally thinking about using
it in header-only mode still. Nothing that can't be change later, though, if
needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unit tests and examples now run again on CSCS premises:
The distributed tests are not enabled as of now (due to current problems with the gitlab runners). Once this is fixed, I will add another PR to enable them.
The tests run automatically for every PR to master, but only for whitelisted users. Manual trigger: make a comment with the content
cscs-ci run default.Other changes: