-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🧹 Fix GCC complaints #2400
Open
thorstenhater
wants to merge
7
commits into
arbor-sim:master
Choose a base branch
from
thorstenhater:qa/fix-warnings-in-tree
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
🧹 Fix GCC complaints #2400
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
aa446db
Fix GCC's paranoia and use iota
thorstenhater 51deda0
More paranoid GCC.
thorstenhater 1dace6e
Clean-up.
thorstenhater d205d8e
Weird GCC ./. Clang issue
thorstenhater 28a0cce
Be extorted by GCC's weird views.
thorstenhater eb4c56e
Honour ADL.
thorstenhater ddb6002
Update arbor/util/range.hpp
thorstenhater File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||||
---|---|---|---|---|---|---|---|---|
|
@@ -158,10 +158,9 @@ template <typename Seq> | |||||||
auto canonical_view(Seq&& s) { | ||||||||
using std::begin; | ||||||||
thorstenhater marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||||
using std::end; | ||||||||
|
||||||||
return make_range( | ||||||||
make_sentinel_iterator(begin(s), end(s)), | ||||||||
make_sentinel_end(begin(s), end(s))); | ||||||||
auto b = begin(s); | ||||||||
auto e = end(s); | ||||||||
return make_range(make_sentinel_iterator(b, e), make_sentinel_end(b, e)); | ||||||||
} | ||||||||
|
||||||||
// Strictly evaluate end point in sentinel-terminated range and present as a range over | ||||||||
|
@@ -170,8 +169,6 @@ auto canonical_view(Seq&& s) { | |||||||
template <typename Seq> | ||||||||
auto strict_view(Seq&& s) { | ||||||||
using std::begin; | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||
using std::end; | ||||||||
|
||||||||
auto b = begin(s); | ||||||||
auto e = end(s); | ||||||||
return make_range(b, b==e? b: std::next(util::upto(b, e))); | ||||||||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
using std::begin; using std::end;
are brought in scope such that ADL works for types that have an overload forbegin()
, see https://en.cppreference.com/w/cpp/iterator/beginThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point! I think all of our containers use a member of
begin
, it's the proper way.