Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce even more GPU allocations #2394

Open
wants to merge 39 commits into
base: master
Choose a base branch
from

Conversation

thorstenhater
Copy link
Contributor

@thorstenhater thorstenhater commented Aug 26, 2024

Bubbling up ion access information from modcc allows us to skip allocation of Xi and Xo iff
no mechanism reads those values.

A minor problem: Sampling may try to touch data that doesn't exist; however who'd ask for Xi
if they never use it?

Stacking this PR on top of #2393 the memory consumption drops by a further 5% down to 77%
if the original value.

Todo

  • Guard against sampling non-existing Xi/Xo

@jlubo
Copy link
Collaborator

jlubo commented Oct 10, 2024

I tested this analogously to PR 2393 and also here, all my tests pass. For the specific case, however, the further reduction in memory consumption is quite small (from 111.5 MB to 109.8 MB).

@thorstenhater
Copy link
Contributor Author

Well, that's expected as this reduction is conditional on certain commonly used things not being used.

@thorstenhater thorstenhater marked this pull request as ready for review October 15, 2024 06:54
jlubo
jlubo previously approved these changes Oct 16, 2024
Copy link
Collaborator

@jlubo jlubo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With many neuronal compartments, I just encountered very high main memory usage, but I guess that is a separate issue.

Regarding this PR, I don't have any further complaints.

arbor/backends/multicore/shared_state.cpp Outdated Show resolved Hide resolved
jlubo
jlubo previously approved these changes Oct 16, 2024
@thorstenhater
Copy link
Contributor Author

The high memory use is a concern, yes, let's discuss that elsewhere, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants