-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spack-solvable versions, add tests to Spack workflow #2156
Merged
brenthuisman
merged 50 commits into
arbor-sim:master
from
brenthuisman:spack_improvements
Aug 7, 2023
Merged
Spack-solvable versions, add tests to Spack workflow #2156
brenthuisman
merged 50 commits into
arbor-sim:master
from
brenthuisman:spack_improvements
Aug 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thorstenhater
requested changes
Jul 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, some wording though (and I am scared of curl | bash
)
thorstenhater
previously approved these changes
Jul 31, 2023
thorstenhater
previously approved these changes
Aug 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Merge remote-tracking branch 'upstream/master' into spack_improvements
Merged
thorstenhater
approved these changes
Aug 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
build_spack_package.sh
. This script does everything in/tmp
, and Github Actions appear to be wiping/tmp
between steps, which means breaking up the run into steps is difficult. Breaking up is desirable, because then one can see whether building or testing breaks.ciwheelbuild
failure.Future issues
Out of scope for now, but identified as problems:
This mean that despite oru
package.py
properly includingdepends_on("[email protected]", type="test", when="@0.7.1:")
, Spack does not build it, at least not in the dev-build workflow as we currently do. And it isn't clear what an always working workaround is, see issue. (Spack can't display the deps for thetest
variant: spack spec/solve include option for --test dependencies spack/spack#23586spack spec -I arbor
doesn't show Google Test, and neither doesspack dependencies --deptype test arbor
.)