Skip to content

Commit

Permalink
Revert Oops, that was not a bug.
Browse files Browse the repository at this point in the history
  • Loading branch information
thorstenhater committed Aug 16, 2023
1 parent e18d9e8 commit 6941d75
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion arbor/communication/communicator.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,9 @@ void update_remote_connections(const connectivity& rec,
for (const auto gid: gids) {
const auto& ext_conns = rec.external_connections_on(gid);
for (const auto& conn: ext_conns) {
if(!is_external(conn.source.rid)) throw arb::source_gid_exceeds_limit(gid, conn.source.rid);
// NOTE: This might look like a bug, but the _remote id_ is consider locally
// in the remote id space, ie must not be already tagged as remote.
if(is_external(conn.source.rid)) throw arb::source_gid_exceeds_limit(gid, conn.source.rid);
gid_ext_connections.emplace_back(conn);
}
part_ext_connections.push_back(gid_ext_connections.size());
Expand Down

0 comments on commit 6941d75

Please sign in to comment.