Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

properly open urls from firefox reader mode page #47

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

wesinator
Copy link

Thanks for the work on this extension.

This PR adds a check to properly handle the case where the current page view is a reader mode (in Firefox), sending the actual raw URL to resurrect pages.

Enter about:reader?url=https%3A%2F%2Fwww.howtogeek.com%2F352267%2Fhow-to-use-the-reader-view-in-firefox%2F in browser and the resurrect pages from the toolbar links.

@arantius
Copy link
Owner

arantius commented Jul 2, 2021

Thanks for the PR. But:

  1. It's got syntax errors (missing closing paren, decodeURIcomponent is not defined).
  2. Coding style doesn't match (indent by two, braces around blocks aren't optional, single quotes around strings)
  3. Even if that's fixed, it functions only from the context menu -- the toolbar button behavior is now inconsistent.

(edit: markdown syntax)

@wesinator
Copy link
Author

@arantius happy new year,

This change is now fixed, tested and works correctly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants