Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update collection.find to support nested fields #354

Merged
merged 1 commit into from
Nov 28, 2024
Merged

Conversation

aMahanna
Copy link
Member

@aMahanna aMahanna commented Nov 18, 2024

db.collection().find(...) was previously not working for nested fields

Happy to go with an alternative solution if there's an easier way

@aMahanna aMahanna requested a review from apetenchea November 18, 2024 23:21
@codecov-commenter
Copy link

codecov-commenter commented Nov 18, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.94%. Comparing base (8e6aaca) to head (e4b5652).
Report is 2 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

❗ There is a different number of reports uploaded between BASE (8e6aaca) and HEAD (e4b5652). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (8e6aaca) HEAD (e4b5652)
3 1
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #354       +/-   ##
===========================================
- Coverage   95.94%   83.94%   -12.00%     
===========================================
  Files          26       26               
  Lines        4296     4299        +3     
===========================================
- Hits         4122     3609      -513     
- Misses        174      690      +516     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aMahanna aMahanna merged commit 623c29b into main Nov 28, 2024
37 checks passed
@aMahanna aMahanna deleted the update-find branch November 28, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants